Optimizing XPath performance using XSLT extensions#793
Open
Honesty-of-the-Cavernous-Tissue wants to merge 2 commits intoadbar:masterfrom
Open
Optimizing XPath performance using XSLT extensions#793Honesty-of-the-Cavernous-Tissue wants to merge 2 commits intoadbar:masterfrom
Honesty-of-the-Cavernous-Tissue wants to merge 2 commits intoadbar:masterfrom
Conversation
Owner
|
Hi @Honesty-of-the-Cavernous-Tissue, while your idea is good in general order matters for these XPath expressions. I advise against it, you would have to be sure to pass the tests and not to degrade the evaluation for your PR to be accepted. |
Owner
|
@Honesty-of-the-Cavernous-Tissue You'd still need to fix type hinting for Python 3.13 and test of there is a regression on the benchmark (see tests Readme). |
Owner
|
@Honesty-of-the-Cavernous-Tissue Are you still working on the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
trafilatura/trafilatura/htmlprocessing.py
Line 95 in 3d7e786