refactor: Move of AdaptiveHT core codes to Core#5403
Open
tboldagh wants to merge 51 commits intoacts-project:mainfrom
Open
refactor: Move of AdaptiveHT core codes to Core#5403tboldagh wants to merge 51 commits intoacts-project:mainfrom
tboldagh wants to merge 51 commits intoacts-project:mainfrom
Conversation
test: created a test for modified AHT exploring algorithm
github-actions
Bot
added
Component - Core
Contributor
andiwand
reviewed
May 5, 2026
Contributor
andiwand
left a comment
andiwand
left a comment
There was a problem hiding this comment.
had a quick first look and flagged a few minor issues with ACTS conventions
std::int32_toverintandstd::uint32_toverunsigned- implicit conversions sonarcloud flagged
inlineafter sonarcloud flagged it- use of
iostreamin Core
apart from that I wondered if we want to put this directly into versioned API or if you planned to do additional breaking changes. this will likely slow down the developments as we would sync them with major version bumps
| #include <cmath> | ||
| #include <concepts> | ||
| #include <functional> | ||
| #include <iostream> // remove me |
Contributor
There was a problem hiding this comment.
Suggested change
| #include <iostream> // remove me |
Comment on lines
+346
to
+350
| std::cerr << "start ss.size: " << sectionsStack.size() << std::endl; | ||
| std::cerr << "start section decision: " | ||
| << (sectionsStack[0].decision() == | ||
| HoughAccumulatorSection::Decision::Drill) | ||
| << std::endl; |
Contributor
There was a problem hiding this comment.
here iostream is still used. is this temporary or can this be done with an Acts::Logger?
Contributor
Author
There was a problem hiding this comment.
It is leftover from debugging. Should be removed.
| #include <iostream> // remove me | ||
| #include <vector> | ||
|
|
||
| namespace Acts { |
Contributor
There was a problem hiding this comment.
depending on how stable the API is we can put it into Acts or Acts::Experimental. in case you still want to change something and we put it into Acts we can only do this with major version changes
Contributor
Author
There was a problem hiding this comment.
Thanks Andi, this is excellent suggestion. Will do.
Precise type specification Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Doxygen fix Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise type of literals Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Precise types Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Fixed inlining, exact types for literals and leftover unsigned -> uint32_t Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR moves the implementation of AdaptiveHT from the test area to the core.
--- END COMMIT MESSAGE ---
In addition the the code cleanup and optimisation it includes as well set of unit tests.
The next step will be replacements in example algorithm
Contributor: @MWojniewski