feat: Add edm4hep tracker hit links to PODIO track container#5354
Merged
kodiakhq[bot] merged 34 commits intoacts-project:mainfrom May 5, 2026
Merged
feat: Add edm4hep tracker hit links to PODIO track container#5354kodiakhq[bot] merged 34 commits intoacts-project:mainfrom
kodiakhq[bot] merged 34 commits intoacts-project:mainfrom
Conversation
github-actions
Bot
added
Component - Examples
Contributor
paulgessinger
force-pushed
the
feat/edm4hep-track-link
branch
from
287630c to
23a77f1
Compare
paulgessinger
force-pushed
the
feat/edm4hep-track-link
branch
from
23a77f1 to
3a7c911
Compare
benjaminhuth
reviewed
May 4, 2026
Member
benjaminhuth
left a comment
benjaminhuth
left a comment
There was a problem hiding this comment.
Looks good to me, just would like to clarify the linear search...
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new utilities and converters for handling EDM4hep and PODIO track and measurement data, with a focus on improved DD4hep integration and enhanced simulation hit linking. It also removes legacy PODIO measurement converters that are now superseded by the new implementations. The most important changes are grouped below:
New Features and Utilities:
PodioTrackOutputConverter, a new algorithm to write ACTS track containers to PODIO/EDM4hep format, preserving all track states and dynamic columns. This converter requiresTrackerHitLocalcollections as input and outputs collections for tracks, track states, and their hit links. (Examples/Io/EDM4hep/include/ActsExamples/Io/EDM4hep/PodioTrackOutputConverter.hpp,Examples/Io/EDM4hep/src/PodioTrackOutputConverter.cpp, [1] [2] [3]DD4hepPodioConversionHelper, a utility class for mapping between ACTS surfaces/source links and DD4hep CellID identifiers, facilitating conversions between ACTS and DD4hep-based geometries. (Examples/Io/EDM4hep/include/ActsExamples/Io/EDM4hep/DD4hepPodioConversionHelper.hpp,Examples/Io/EDM4hep/src/DD4hepPodioConversionHelper.cpp, [1] [2] [3]Enhancements to Measurement Output Conversion:
EDM4hepMeasurementOutputConverterto optionally support simulation hit linking. This includes new config options and data handles for sim hit associations and mappings, as well as logic to writeTrackerHitLocalSimTrackerHitLinkcollections and ensure configuration consistency. (Examples/Io/EDM4hep/include/ActsExamples/Io/EDM4hep/EDM4hepMeasurementOutputConverter.hpp,Examples/Io/EDM4hep/src/EDM4hepMeasurementOutputConverter.cpp, [1] [2] [3] [4] [5] [6]Codebase Cleanup and Removal of Deprecated Components:
PodioMeasurementOutputConverterandPodioMeasurementInputConverter) and their associated source/header files, as their functionality is now covered by the new EDM4hep converters. (Examples/Io/Podio/CMakeLists.txt,Examples/Io/Podio/include/ActsExamples/Io/Podio/PodioMeasurementInputConverter.hpp, [1] [2]Minor Improvements:
Examples/Io/EDM4hep/include/ActsExamples/Io/EDM4hep/EDM4hepTrackOutputConverter.hpp, Examples/Io/EDM4hep/include/ActsExamples/Io/EDM4hep/EDM4hepTrackOutputConverter.hppL29-R29)These changes modernize the EDM4hep/PODIO output pipeline, provide robust DD4hep integration, and ensure that simulation and reconstruction data are more accurately linked and exported.