feat: muon buckets sector frame + bucket splitting#5229
Open
davidedicroce wants to merge 12 commits intoacts-project:mainfrom
Open
feat: muon buckets sector frame + bucket splitting#5229davidedicroce wants to merge 12 commits intoacts-project:mainfrom
davidedicroce wants to merge 12 commits intoacts-project:mainfrom
Conversation
dimitra97
reviewed
Mar 10, 2026
dimitra97
reviewed
Mar 10, 2026
davidedicroce
changed the title
|
Contributor
junggjo9
reviewed
Mar 31, 2026
| const double var0 = cov[0]; | ||
| const double var1 = cov[1]; | ||
| const double maxVar = std::max({0., var0, var1}); | ||
| return sigmaScale * std::sqrt(maxVar); |
Contributor
There was a problem hiding this comment.
Wait that's a bit edgy. The variances describe the measurement's uncertainty in x and y. How does this relate?
Comment on lines
+132
to
+133
| if (trackingGeometry.findVolume(volId) != nullptr) { | ||
| return volId; |
Contributor
There was a problem hiding this comment.
How is it possible that an invalid volume identifier is in the list?
Co-authored-by: junggjo9 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR introduces sector-based muon bucketization for the GeoModel mockup workflow and aligns the mockup geometry IDs so digitization can consistently resolve a common sector frame.
1. MuonSpacePointDigitizer:
2. GeoModelMuonMockupBuilder:
3. Examples/Scripts/Python/geomodel_G4.py:
4. Examples/Detectors/MuonSpectrometerMockupDetector/src/GeoMuonMockupExperiment.cpp:
5. Python/Examples/src/Digitization.cpp:
@dimitra97 @junggjo9