Explosives - Taking bounding box into consideration when attaching#11335
Open
deBearN wants to merge 6 commits intoacemod:masterfrom
Open
Explosives - Taking bounding box into consideration when attaching#11335deBearN wants to merge 6 commits intoacemod:masterfrom
deBearN wants to merge 6 commits intoacemod:masterfrom
Conversation
DartRuffian
reviewed
Apr 3, 2026
Contributor
DartRuffian
left a comment
DartRuffian
left a comment
There was a problem hiding this comment.
Formatting, make variables private
Co-authored-by: Dart <[email protected]>
Co-authored-by: Dart <[email protected]>
Co-authored-by: Dart <[email protected]>
PabstMirror
reviewed
Apr 3, 2026
PabstMirror
reviewed
Apr 3, 2026
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
Drofseh
changed the title
PabstMirror
changed the title
johnb432
reviewed
Apr 4, 2026
Comment on lines
+212
to
+214
| if (_normal isEqualTo [0,0,0]) then { | ||
| _normal = surfaceNormal _posASL; | ||
| }; |
Contributor
There was a problem hiding this comment.
What's this part of the code supposed to catch?
Author
There was a problem hiding this comment.
Here? probably nothing, i got some of my code from one of my scripts that had vectors in them, so it was probably left-over from something, in case the object bottom was pointing at the sky resets it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously objects would clip into the object it was being place in:
Now using their bounding box i move them so they stay right on the limit as if they were properly attached:
Seems to work with most modded explosives (i didn't find one it didn't work with).
The "problem" with the fix is having to re-calculate the
_basePosASLwhen you can place it, because i need the Object from _expSetupVehicle to get the bounding box, feel free to give me directions on how to improve it.also double check if i did this correctly because my fork path is ACE3>>MyUnitFork>>MyFork, so i had to create a branch, do a hard reset to upstream(ACE3) and then commit and publish, want to make sure it's all good.