feat: integrate prettier and enforce code formatting #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
As we discussed in today's call, I've implemented Prettier for consistent formatting and added a CI check to enforce it. I’ve also run the tests, linting, and Prettier locally, and everything passed successfully with no issues. Note: To keep |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| */ | ||
| toAvroName(name) { | ||
| // $ is unfortunately a restricted character in Avro! | ||
| return name.replace('$', '_'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| */ | ||
| toGraphQLName(name) { | ||
| // $ is unfortunately a restricted character in GraphQL! | ||
| return name.replace('$', '_').replace(/\./g, '_'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| * @returns {string} a valid XSD NCName | ||
| */ | ||
| toXsName(name) { | ||
| return name.replace('$', '_'); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
Signed-off-by: Rahul-R79 <[email protected]>
Rahul-R79
force-pushed
the
feat/add-prettier
branch
from
dc1c6a9 to
a11a36e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #191
This PR integrates Prettier into the project to handle code formatting, separating stylistic concerns from code quality checks (ESLint). It also adds a mandatory formatting check in the CI pipeline.
Changes
prettierandeslint-config-prettier.npm run format(write) andnpm run format:check(verify) to package.json.prettier, disabling conflicting formatting rules.npm run format:checkstep to .github/workflows/build.yml to fail builds on formatting errors.Flags
.git-blame-ignore-revs(in a follow-up PR) to preservegit blameusability.Screenshots or Video
N/A (Formatting changes only)
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:feat/add-prettier