fix: prevent Agreement.uri from overriding resource URI#129
Closed
Thomas-Sedhom wants to merge 2 commits intoaccordproject:mainfrom
Closed
fix: prevent Agreement.uri from overriding resource URI#129Thomas-Sedhom wants to merge 2 commits intoaccordproject:mainfrom
Agreement.uri from overriding resource URI#129Thomas-Sedhom wants to merge 2 commits intoaccordproject:mainfrom
Conversation
Signed-off-by: thomas sedhom <thomassedhom97@gmail.com>
a69fdac to
8d776c9
Compare
Signed-off-by: thomas sedhom <thomassedhom97@gmail.com>
f31df45 to
b33fd50
Compare
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
Author
|
This work has been continued in #164 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
getAgreements, the object spread ...a was placed after the explicitly defined uri field. Since Agreement has its own uri property, it was silently overwriting the apap://agreements/${a.id} URI we were trying to set — meaning MCP clients were getting the wrong URI back.Solution
Moved
...ato the top of the returned object so that our explicituri,mimeType, and text fields always take precedence over whatever's on the schema.And it finally return the correct URI:
Fixes: #128