ipvs: Remove duplicate virtual servers during config validation#2644
Open
lxchx wants to merge 1 commit intoacassen:masterfrom
Open
ipvs: Remove duplicate virtual servers during config validation#2644lxchx wants to merge 1 commit intoacassen:masterfrom
lxchx wants to merge 1 commit intoacassen:masterfrom
Conversation
The current IPVS implementation allows duplicate virtual server (VS) configurations. While IPVS ensures only the first VS takes effect, the presence of redundant VS entries in the keepalived state can be confusing. Furthermore, checkers for these remaining duplicate VS still perform unnecessary work. This commit actively detects and removes duplicate virtual servers during configuration validation. To maintain compatibility with existing configurations that might implicitly rely on this behavior, this change preserves the first encountered VS.
Author
|
This configuration might be helpful: When the --dump-conf parameter is enabled, Keepalived retains two duplicate virtual server (VS) configurations. Furthermore, all four misc_checker instances remain active, even though the real servers associated with check_wrr_rs1.sh and check_wrr_rs2.sh are effectively shadowed or superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current IPVS implementation allows duplicate virtual server (VS) configurations. While IPVS ensures only the first VS takes effect, the presence of redundant VS entries in the keepalived state can be confusing. Furthermore, checkers for these remaining duplicate VS still perform unnecessary work.
This commit actively detects and removes duplicate virtual servers during configuration validation. To maintain compatibility with existing configurations that might implicitly rely on this behavior, this change preserves the first encountered VS.