Open
Conversation
- Fix broadcasting error in test_ppi_mean_multid. - Change lambd_optim_mode to lam_optim_mode in test_ppi_mean_elem. - Change confromal baseline to use np.inf instead of np.infty.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed tests in
tests/test_mean.py,tests/test_cross.pyandtests/test_logistic.py.For
test_mean.pytest_ppi_mean_multid.lambd_optim_modetolam_optim_modeintest_ppi_mean_elem.np.infinstead ofnp.infty.For
test_cross.pyandtest_logistic.pychanged the synthetic data generation in de-biasing tests to use binomial sampling instead of a threshold. This ensures the synthetic data is generated from a logistic model and so biased can be computed.Also formatted entire repo with black.