fix ionic bug - dragged item not being displayed#330
Open
Ronnnn wants to merge 1 commit intoa5hik:masterfrom
Open
fix ionic bug - dragged item not being displayed#330Ronnnn wants to merge 1 commit intoa5hik:masterfrom
Ronnnn wants to merge 1 commit intoa5hik:masterfrom
Conversation
…ing the dragged item not to be shown
Closed
Owner
|
@Ronnnn thanks for the PR, can you confirm the demo page works in major browsers after this change. So that I can merge. |
|
I've got the same issue, but the fix doesn't work unfortunately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ionic 1.3.1 the scollable container offset is not being calculated properly. The y offset becomes negative and thus the dragged item is not being displayed at all. This fixes that issue.
== Needs testing for relative containers