php8.4#41
Merged
rdss-sknott merged 32 commits intomainfrom Apr 7, 2025
Merged
Conversation
rdss-pkuehn
approved these changes
Mar 31, 2025
rdss-pkuehn
force-pushed
the
php8.4
branch
2 times, most recently
from
1f8fa62 to
2540b7e
Compare
farzamtm
approved these changes
Mar 31, 2025
rdss-pkuehn
approved these changes
Mar 31, 2025
rdss-hmorsi
approved these changes
Mar 31, 2025
farzamtm
approved these changes
Apr 4, 2025
rdss-pwacht
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for testing:
checkout coding-standard-source (1)
go into a different php project (2) e.g https://github.com/ZooRoyal/itv-microservice-php
set php req in composer json to 8.4
run in a terminal in the dir of (2) the command:
<path-to-(1)>/tests/run-coding-standard.sh sca:allgo into another different php project (3)
keep php version in composer.json as is
run in a terminal in the dir of (3) the command:
<path-to-(1)>/tests/run-coding-standard.sh sca:allthe only
errorsraised should be cs violations if present