Merged
Conversation
Qmando
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was dealing with the odd problem of container tracing working fine when I called it, but not when run by systemd, and I figured that we had a wrapper in user envs to set the containerd namespace var properly, which of course would not be present when systemd would launch the daemon process.
Rather than address the issue in the systemd unit (which would be pretty trivial tbf), I went for a small code update the make tracing more flexible, and with a default behaviour tailored for our use cases (aka trace k8s pods).
While I was at it, I also added a couple more logging points about the container tracing background thread doing its job.