Conversation
Rob-Johnson
suggested changes
Apr 27, 2020
Contributor
Rob-Johnson
left a comment
Rob-Johnson
left a comment
There was a problem hiding this comment.
we're going to need some tests to protect ourselves against regressions, but looks a good start
mks-m
force-pushed
the
u/maksym/paasta-metastatus
branch
from
cc82c96 to
802f963
Compare
* Adding support to get Yaml for k8s object * Added logic to compute yaml diff, refactored hashing helper * Nit changes for review * Updating link for unified context
Also add an indirect dependency for reflect2
Let's not use an accessor for Client access, if public field is sufficient
added 11 commits
May 4, 2020 12:36
…llel for all requested clusters
mks-m
force-pushed
the
u/maksym/paasta-metastatus
branch
from
665bcc1 to
50ea198
Compare
mks-m
force-pushed
the
u/maksym/paasta-api
branch
from
e03353b to
5074eaf
Compare
mks-m
requested review from
Rob-Johnson and
vkhromov
and removed request for
Bronek
vkhromov
approved these changes
Nov 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Translated python version in here, uses configstore branch to load configs. The big thing is of course pkg/paasta_api that is generated by go-swagger, there are still some issues with it, I found a name conflict in InstanceStateFlink, there may be other things, but for current use case it works.
Don't bother reading/reviewing autogenerated api of course, only
cmd/paasta-metastatus/main.go.