Conversation
|
Ah, oof :-) |
YannickJadoul
force-pushed
the
add-pointprocess-class
branch
from
363156a to
a7b8a99
Compare
YannickJadoul
left a comment
YannickJadoul
left a comment
There was a problem hiding this comment.
This is great; I hadn't realized it was such a nicely contained set of changes!
What I've done so far in the two extra commits (go ahead and check) is mainly making sure that the full diff doesn't show difference that are just indentation or style changes. Now that there's a contributor, I should definitely get a .clang-format file, but adding and applying that is probably best left outside of this PR (to ensure we focus on the important parts and content here!).
Also, a few things to discuss that I've noticed. Apart from that, I'll dive into the details soon, but something tells me I won't have a lot of work to do :-)
hokiedsp
force-pushed
the
add-pointprocess-class
branch
from
e37d662 to
ed911bf
Compare
|
The last commit should truly be the last commit to this PR from me. Added |
YannickJadoul
force-pushed
the
add-pointprocess-class
branch
2 times, most recently
from
af4b1f6 to
19bde38
Compare
YannickJadoul
force-pushed
the
master
branch
from
2b2f650 to
28ae186
Compare
YannickJadoul
force-pushed
the
master
branch
2 times, most recently
from
36b9043 to
b6595d3
Compare
hokiedsp
force-pushed
the
add-pointprocess-class
branch
3 times, most recently
from
359b8ba to
dff9aa9
Compare
…o runnable pytest test
- shimmer functions - alternate constructors - create_poisson_process() - get_time_points() - add_points() Moved lines around for readability Removed _t & _nt Added method docstrings
get_count_and_fraction_of_voice_breaks() returns 4-element tuple
Added PointProcess.__len__(), .__getitem__(), & __iter__() Updated test
Fixed PointProcess empty constructor
pytest: dropped 'eee.wav', using global fixtures
to_text_grid_vuv(), to_sound_phonation(), to_sound_pulse_train(), to_sound_hum(), - Added class docstring and docstrings of new methods
Added PeakInterpolation enum Updated pytest
- PointProcess.get_shimmer_local_db
Corrected errors in Pitch docstrings
… that py::array_t is accepted in PointProcess constructor and PointProcess.add_points, and some minor fixes to Pitch's PointProcess methods
for more information, see https://pre-commit.ci
hokiedsp
force-pushed
the
add-pointprocess-class
branch
from
9a61aec to
bdc4b11
Compare
2 participants
Here is the renamed PR for PointProcess class.
I renamed my
mydevbranch toadd-pointprocess-classand it apparently closed the original PR automatically.CrossRef: #41,
TODOs
pytestto_PointProcess()methods to the source classesPointProcess.to_XXX()methods to convert from PointProcessPointProcessxtor taking a sequence-like object (which implements__len__()and__getitem__(int)PointProcessa sequence-like class by implementing__len__()and__getitem__(int).