Skip to content

Merge current modules from yc.o#1700

Merged
einarnn merged 38 commits intoYangModels:mainfrom
ietf-tools:clean-pr-branch
Apr 1, 2026
Merged

Merge current modules from yc.o#1700
einarnn merged 38 commits intoYangModels:mainfrom
ietf-tools:clean-pr-branch

Conversation

@xorrkaz
Copy link
Copy Markdown
Contributor

@xorrkaz xorrkaz commented Mar 19, 2026

No description provided.

@xorrkaz xorrkaz mentioned this pull request Mar 19, 2026
Copy link
Copy Markdown
Member

@einarnn einarnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xorrkaz will you be investigating the check failure?

@xorrkaz
Copy link
Copy Markdown
Contributor Author

xorrkaz commented Mar 23, 2026

I have. The fault lies with me. I'm trying to do better, but yc.o is still a back-burner project for me.

@vvilimek
Copy link
Copy Markdown

To fix the checks, you can apply attached patch
ietf-template@2023-07-26.yang.patch

@xorrkaz
Copy link
Copy Markdown
Contributor Author

xorrkaz commented Mar 26, 2026

We have to be a bit "easy" on the extracted-from-drafts set of modules as those can and will have errors. I don't think we should fix them outside of the automation process. That said, the authors of the template draft might appreciate your patch.

@vvilimek
Copy link
Copy Markdown

Agreed. Also, it is hard to find the original source of the YANG module. But why is draft included in the standard/RFC dir?

@vvilimek
Copy link
Copy Markdown

So the ietf-template@2023-07-26.yang is part of RFC 9907: Guidelines for Authors and Reviewers of Documents Containing YANG Data Models. Don't ask me why the module is not well-formed. We might try to fix the syntax errors by erratum, but for now, I think it would be easier and faster to just exclude the file from the performed checks. There is no way the latest ietf-template would passed the required checks. This is better solution than applying the patch because we want to keep same file content as from the RFC document.

@xorrkaz
Copy link
Copy Markdown
Contributor Author

xorrkaz commented Mar 27, 2026

Ha! I saw template, and I thought this was the template work being discussed in NETMOD. Errata might be declined since what they're doing is intentional. They're even registering this with IANA...hmmm. Let me reach out to Med and let him know the impact this is having.

@xorrkaz
Copy link
Copy Markdown
Contributor Author

xorrkaz commented Mar 27, 2026

These are Med's comments on this:

The registration is mainly to avoid that name is used by other modules.
 
Please note that 9907 registered it as well because this was the approach followed since 6087:
 
ietf-template
ietf-template@2010-05-18.yang
N
urn:ietf:params:xml:ns:yang:ietf-template
temp
[RFC6087]
ietf-template
ietf-template@2016-03-20.yang
N
urn:ietf:params:xml:ns:yang:ietf-template
temp
[RFC8407]
ietf-template
ietf-template@2023-07-26.yang
N
urn:ietf:params:xml:ns:yang:ietf-template
temp
[RFC9907]
 
The approach in 9907 was to avoid blind copy/paste and let the authors complete relevant part of the template. I understand this has the side effect of breaking validation, but that’s OK.

I'm not happy with the, "that's okay" response. This is the only standard module that is syntactically incorrect. But, it doesn't bode well for any errata to get it fixed. So, it may be better for Einar to special-case this module in the CI flow.

@xorrkaz
Copy link
Copy Markdown
Contributor Author

xorrkaz commented Mar 27, 2026

See #1703 for a workaround for this going forward.

@vvilimek
Copy link
Copy Markdown

Haha, same response.

..., but that's ok.

Nice. I was not expecting that. I am having a great fun 😄 ! The rationale makes sense.

@einarnn einarnn merged commit 8ada3d3 into YangModels:main Apr 1, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants