Draft
Conversation
Collaborator
sappenin
commented
Feb 3, 2026
- Allow an empty PublicKey to be built using an empty builder
- Add unit tests to verify functionality.
* Allow an empty PublicKey to be built using an empty builder * Add unit tests to verify functionality. Signed-off-by: David Fuelling <sappenin@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
=========================================
Coverage 92.53% 92.53%
- Complexity 2103 2104 +1
=========================================
Files 432 432
Lines 5735 5737 +2
Branches 510 510
=========================================
+ Hits 5307 5309 +2
Misses 280 280
Partials 148 148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sappenin
commented
Feb 9, 2026
| * @return An instance of {@link UnsignedByteArray}. | ||
| */ | ||
| UnsignedByteArray value(); | ||
| @Default |
Collaborator
Author
There was a problem hiding this comment.
After considering this further, we should remove the empty builder so that developers don't accidentally omit an actual value. Instead, we should update EMPTY_PUBLIC_KEY to be this:
PublicKey EMPTY_PUBLIC_KEY = PublicKey.builder().value(UnsignedByteArray.empty()).build();That way, if someone wants to overtly use an empty public key, it will be obvious they are do as much.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.