Conversation
There was a problem hiding this comment.
Pull request overview
Adds optional TLS configuration to the gRPC server and updates tests/docs to support TLS/mTLS scenarios.
Changes:
- Parse
ssl_cert/ssl_key/ssl_chainfrom[port_grpc]and build gRPC server credentials accordingly. - Add envconfig helpers to generate TLS-enabled gRPC configs for tests.
- Add a new unit test suite plus example config documentation for gRPC TLS settings.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
src/xrpld/app/main/GRPCServer.h |
Stores TLS config paths and declares a credentials factory helper. |
src/xrpld/app/main/GRPCServer.cpp |
Reads TLS settings from config and switches gRPC listener credentials to TLS when configured. |
src/test/jtx/impl/envconfig.cpp |
Adds helper functions to populate TLS fields in test configs. |
src/test/jtx/envconfig.h |
Declares the new TLS-related envconfig helpers. |
src/test/app/GRPCServerTLS_test.cpp |
Introduces tests intended to cover TLS and “mTLS” gRPC startup paths. |
cfg/xrpld-example.cfg |
Documents the new [port_grpc] TLS settings and provides example values. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
src/xrpld/app/main/GRPCServer.cpp:10
#include <boost/filesystem.hpp>appears to be unused in this file (noboost::filesystemsymbols are referenced). Consider removing it to reduce compile time and avoid unnecessary dependencies (FileUtilities.h already brings in the needed Boost types).
namespace xrpl {
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6374 +/- ##
=========================================
+ Coverage 80.0% 80.2% +0.2%
=========================================
Files 846 846
Lines 65700 65774 +74
Branches 7257 7181 -76
=========================================
+ Hits 52547 52730 +183
+ Misses 13153 13044 -109
🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
High Level Overview of Change
This PR enhances the gRPC server with optional TLS and mTLS support.
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)