Skip to content

feat: SmartEscrow fee voting changes#5810

Open
mvadari wants to merge 45 commits intoripple/wasmi-host-functionsfrom
ripple/se/fees
Open

feat: SmartEscrow fee voting changes#5810
mvadari wants to merge 45 commits intoripple/wasmi-host-functionsfrom
ripple/se/fees

Conversation

@mvadari
Copy link
Collaborator

@mvadari mvadari commented Sep 22, 2025

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

@mvadari mvadari marked this pull request as ready for review September 22, 2025 22:23
@codecov
Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 95.04132% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.5%. Comparing base (1b4a564) to head (5148098).

Files with missing lines Patch % Lines
src/xrpld/app/ledger/Ledger.cpp 84.0% 4 Missing ⚠️
src/libxrpl/tx/transactors/Change.cpp 90.9% 1 Missing ⚠️
src/xrpld/app/misc/FeeVoteImpl.cpp 98.2% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           ripple/wasmi-host-functions   #5810   +/-   ##
===========================================================
  Coverage                         80.5%   80.5%           
===========================================================
  Files                              861     861           
  Lines                            67751   67843   +92     
  Branches                          7285    7287    +2     
===========================================================
+ Hits                             54544   54629   +85     
- Misses                           13207   13214    +7     
Files with missing lines Coverage Δ
include/xrpl/protocol/Fees.h 100.0% <ø> (ø)
include/xrpl/protocol/detail/ledger_entries.macro 100.0% <ø> (ø)
include/xrpl/protocol/detail/transactions.macro 100.0% <ø> (ø)
src/libxrpl/protocol/STValidation.cpp 80.6% <ø> (ø)
src/xrpld/app/misc/NetworkOPs.cpp 70.8% <100.0%> (+0.4%) ⬆️
src/xrpld/core/Config.h 84.6% <ø> (ø)
src/xrpld/core/detail/Config.cpp 78.4% <100.0%> (+0.3%) ⬆️
src/libxrpl/tx/transactors/Change.cpp 85.6% <90.9%> (+0.3%) ⬆️
src/xrpld/app/misc/FeeVoteImpl.cpp 95.4% <98.2%> (+0.3%) ⬆️
src/xrpld/app/ledger/Ledger.cpp 82.4% <84.0%> (+<0.1%) ⬆️

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mvadari mvadari changed the base branch from ripple/wamr-host-functions to ripple/wasmi-host-functions November 24, 2025 21:56
@mvadari mvadari mentioned this pull request Dec 2, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments