feat: Metrics for requested ledger age#2947
Open
kuznetsss wants to merge 11 commits intoXRPLF:developfrom
Open
feat: Metrics for requested ledger age#2947kuznetsss wants to merge 11 commits intoXRPLF:developfrom
kuznetsss wants to merge 11 commits intoXRPLF:developfrom
Conversation
Add prometheus metrics to track ledger request patterns: - rpc_ledger_requests_total: Counter with labels for current/validated/specific - rpc_ledger_age_seconds: Histogram for ledger age in seconds (approximate) - rpc_ledger_age_ledgers: Histogram for ledger age in ledger count This enables analysis of how often users request old ledgers. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Add recordLedgerMetrics call after successful RPC request completion to track ledger request patterns. This is called in both old and new RPCServerHandler implementations. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Add comprehensive tests for the new ledger metrics: - Test current ledger requests - Test validated ledger requests (both explicit and default) - Test specific ledger number requests (numeric and string) - Test ledger hash requests - Test zero age (same as current ledger) Also update MockRPCEngine to include recordLedgerMetrics method. All 18 RPC counter tests passing. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
godexsoft
reviewed
Feb 13, 2026
Collaborator
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
Looks pretty useful overall!
kuznetsss
commented
Feb 13, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2947 +/- ##
========================================
Coverage 82.00% 82.01%
========================================
Files 391 391
Lines 14689 14717 +28
Branches 8037 8054 +17
========================================
+ Hits 12046 12070 +24
- Misses 1459 1461 +2
- Partials 1184 1186 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kuznetsss
force-pushed
the
Add_age_metric
branch
from
80f64d7 to
344b1d4
Compare
kuznetsss
force-pushed
the
Add_age_metric
branch
2 times, most recently
from
3992999 to
4e8d3c1
Compare
…tests The previous ledger metrics implementation added calls to recordLedgerMetrics in the RPC server handlers, but the NgRpcServerHandler tests were missing mock expectations for these calls. This caused 6 tests to fail with 'Uninteresting mock function call' errors. This commit adds EXPECT_CALL expectations for recordLedgerMetrics in all successful request test cases where the metrics are recorded.
- Remove ledgerAgeSecondsHistogram metric (not needed, only track by ledger count) - Move recordLedgerMetrics call into notifyComplete(Context) overload - Keep early return for ledger_hash requests (can't determine age) - Update all tests to match new implementation
kuznetsss
force-pushed
the
Add_age_metric
branch
from
4e8d3c1 to
bfb6379
Compare
kuznetsss
force-pushed
the
Add_age_metric
branch
from
bfb6379 to
57be9d0
Compare
godexsoft
reviewed
Feb 17, 2026
Collaborator
godexsoft
left a comment
godexsoft
left a comment
There was a problem hiding this comment.
I found one more potential thing to fix but i don't have a solution for it.
src/rpc/Counters.cpp
Outdated
| void | ||
| Counters::recordLedgerRequest(boost::json::object const& params, std::uint32_t currentLedgerSequence) | ||
| { | ||
| if (not params.contains("ledger_index")) { |
Collaborator
There was a problem hiding this comment.
There is also "ledger_hash" that can be used to refer to the same ledger.. not sure how to deal with it though.
Collaborator
Author
There was a problem hiding this comment.
I don't think there is an easy way to get ledger index by hash and querying DB or rippled for that is probably too heavy operation.
Collaborator
Author
There was a problem hiding this comment.
Added a counter for requests with ledger_hash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding metrics to be able to analyse requested ledger age distribution.