Fix RCON issues: crashes, memory leaks, and display bugs#255
Open
fred0r wants to merge 2 commits intoXQF:masterfrom
Open
Fix RCON issues: crashes, memory leaks, and display bugs#255fred0r wants to merge 2 commits intoXQF:masterfrom
fred0r wants to merge 2 commits intoXQF:masterfrom
Conversation
fred0r
commented
Apr 7, 2026
fred0r
commented
- Fix crash when adding RCON password (dangling pointer)
- Duplicate rcon_challenge to prevent invalid memory access
- Add const qualifiers to fix compiler warnings
- Append RCON output instead of replacing (see all plugins)
- Read all available RCON packets in callback loop (fix partial data)
added 2 commits
April 7, 2026 09:59
- Fix crash when adding RCON password (dangling pointer) - Duplicate rcon_challenge to prevent invalid memory access - Add const qualifiers to fix compiler warnings - Append RCON output instead of replacing (see all plugins) - Read all available RCON packets in callback loop (fix partial data)
Store actual message size from rcon_receive() and use it instead of strlen() in rcon_input_callback(). This fixes truncation when AMX Mod X plugin output contains embedded null bytes as column separators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.