Add flag to print to stdout #57 #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
pretty sure -d does this already |
Collaborator
|
the printing to stdout i mean |
Contributor
Author
|
D also adds some debug print statements, the stdout flag dosnt. -d also sets the global sebug flag. I think these should be separate flags because -d has more functionality and will prpbably be used for more debugging in the future. |
Collaborator
|
fair enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #57 by adding a function
tsync::generate_typescript_defs_innerthat returnsBuildState. I also added the commandline flag--stdoutthat prints the content to stdout, not to a file. However you still need to specify an output file, that will not be written to, a full filename is not required, just the extention with the leading period.All the tests pass, and the signature of generate_typescript_defs remained unchanged as not to break compatability with earlier versions.