Upgrade to Elasticsearch 9.1.4 by johnnyshields · Pull Request #174 · WorksApplications/elasticsearch-sudachi

johnnyshields · 2025-10-25T13:01:46Z

Upgrade to Elasticsearch 9.1.4

This PR also does the following:

Upgrade Java to JVM 21
Upgrade Gradle to 8.11
Fix all deprecations
Fix integrations tests on Elasticsearch and re-enable them
Fixes the library to use the new entitlement-policy.yaml framework.
- As part of this, in ES9 we can now ONLY load dicts, char.def, and subplugins from the config/sudachi directory. It is no longer allowed to load them from the root dir or other places.
- entitlement-policy also forces us to load sudachi.jar directly, and require its files using .andThen(PathAnchor.classpath(ConfigAdapter::class.java)).

Follow-up Ticket:

After these changes, Sudachi loads, but there still seem to be some entitlement policy failures in the log lines. These may be silent failures; it looks like ES still ultimately loads.

I believe these are coming from the com.worksap.nlp.sudachi.PathAnchor class (see below). It seems like it's trying to load from the user's home dir first (not allowed by entitlement-policy.yaml). Possible solutions:

Make PathAnchor not attempt to access the home dir, or alternatively, make a "locked down" mode where it doesn't do this (i.e. when "Anchored")
Change entitlement-policy.yaml to allow accessing the user's home dir --> strongly not preferred, would prefer to keep security locked down as per other ES plugin standards.

[2025-10-28T20:34:11,591][WARN ][o.e.e.r.p.P.a.A.c.w.n.sudachi] [DESKTOP-G8M5HPP] Not entitled: component [analysis-sudachi], module [ALL-UNNAMED], class [class com.worksap.nlp.sudachi.PathAnchor], entitlement [file], operation [read], path [char.def]org.elasticsearch.entitlement.runtime.api.NotEntitledException: component [analysis-sudachi], module [ALL-UNNAMED], class [class com.worksap.nlp.sudachi.PathAnchor], entitlement [file], operation [read], path [char.def]
        at [email protected]/org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.notEntitled(PolicyCheckerImpl.java:467)
        at [email protected]/org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.checkFileRead(PolicyCheckerImpl.java:245)
        at [email protected]/org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.checkFileRead(PolicyCheckerImpl.java:208)
        at [email protected]/org.elasticsearch.entitlement.runtime.policy.ElasticsearchEntitlementChecker.check$java_nio_file_Files$$exists(ElasticsearchEntitlementChecker.java:2193)
        at java.base/java.nio.file.Files.exists(Files.java)

See logs for more details.

[2025-10-28T20:34:11,592][WARN ][o.e.e.r.p.P.a.A.c.w.n.sudachi] [DESKTOP-G8M5HPP] Not entitled: component [analysis-sudachi], module [ALL-UNNAMED], class [class com.worksap.nlp.sudachi.PathAnchor], entitlement [file], operation [read], path [unk.def]org.elasticsearch.entitlement.runtime.api.NotEntitledException: component [analysis-sudachi], module [ALL-UNNAMED], class [class com.worksap.nlp.sudachi.PathAnchor], entitlement [file], operation [read], path [unk.def]
        at [email protected]/org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.notEntitled(PolicyCheckerImpl.java:467)
        at [email protected]/org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.checkFileRead(PolicyCheckerImpl.java:245)
        at [email protected]/org.elasticsearch.entitlement.runtime.policy.PolicyCheckerImpl.checkFileRead(PolicyCheckerImpl.java:208)
        at [email protected]/org.elasticsearch.entitlement.runtime.policy.ElasticsearchEntitlementChecker.check$java_nio_file_Files$$exists(ElasticsearchEntitlementChecker.java:2193)
        at java.base/java.nio.file.Files.exists(Files.java)

- Upgrade Java to JVM 21 - Upgrade Gradle to 8.11 - Fix all deprecations - Fix integrations tests on Elasticsearch and re-enable them

- Move sudachi lib requirement as a direct implementation dep (otherwise breaks entitlement policy) - Add entitlement policy test

johnnyshields · 2025-10-28T10:38:43Z

build.gradle


+java {
+    sourceCompatibility = JavaVersion.VERSION_21
+    targetCompatibility = JavaVersion.VERSION_21


JVM 21 is required by ES9

johnnyshields · 2025-10-28T10:39:02Z

build.gradle

    var esKind = sudachiEs.kind.get()
    dependsOn embedVersion, packageJars, packageSpiJars
-    archiveBaseName.set("${esKind.engine.kind}-${esKind.version}-$archivesBaseName")
+    archiveBaseName.set("${esKind.engine.kind}-${esKind.version}-${base.archivesName.get()}")


This is a deprecation fix in gradle

johnnyshields · 2025-10-28T10:39:36Z

buildSrc/src/main/groovy/com/worksap/nlp/tools/EsTestEnvPlugin.groovy

 class EsTestEnvExtension {
    Path bundlePath = null
-    Path systemDic = null
-    Path configFile = null


These are now handled by addConfigFile (see below)

johnnyshields · 2025-10-28T10:40:59Z

build.gradle

 dependencies {
-    spi(project(':spi'))
+    implementation(project(':spi'))
+    implementation('com.worksap.nlp:sudachi:0.7.4')


This is required to load the sudachi jar in ES9. We can't use the previous dynamic loading anymore due to entitlement-policy.yaml

johnnyshields · 2025-10-28T10:41:34Z

build.gradle

-        into "build/package/${version}/${esKind.engine.kind}-${esKind.version}/spi"
-    } else {
-        into "build/package/${version}/${esKind.engine.kind}-${esKind.version}"
-    }


See above, we can't do dynamic loading due to entitlement-policy.yaml--at least I couldn't get it to work.

johnnyshields · 2025-10-28T12:27:57Z

src/main/java/com/worksap/nlp/elasticsearch/sudachi/ConfigAdapter.kt

  private val basePath = resourcesPath(env, settings)
-  private val fullAnchor = PathAnchor.filesystem(basePath).andThen(anchor)
+  private val fullAnchor =
+      PathAnchor.filesystem(basePath).andThen(PathAnchor.classpath(ConfigAdapter::class.java))


In this method ConfigAdapter(anchor: PathAnchor...), the anchor arg is no longer used in my code b/c we are now from forcing to load from either (1) config/sudachi dir or the (2) sudachi.jar itself. Things seem to work fine but perhaps I'm missing something. Perhaps we can remove the anchor arg entirely.

Note also the change to use ConfigAdapter::class.java. This is related to the fact that we are now loading the sudachi jar directly.

It would be a good idea to write more tests for this ConfigAdapter class so we can understand all usage scenarios.

hayashi-mas-wap

LGTM about the es:9.1.4 part.

We want to keep using java 17 for the older es/os versions, so please switch it following #176. (workflows/build.yml, release.yml, buildSrc/../EsConventions.groovy and build.gradles)

Upgrade to Elasticsearch 9.1.4. As part of this:

1459ea9

- Upgrade Java to JVM 21 - Upgrade Gradle to 8.11 - Fix all deprecations - Fix integrations tests on Elasticsearch and re-enable them

johnnyshields force-pushed the es-upgrade-9.1.4 branch 5 times, most recently from f89efdb to 0994c0a Compare October 28, 2025 08:29

- Fix entitlement policy

0ddb019

- Move sudachi lib requirement as a direct implementation dep (otherwise breaks entitlement policy) - Add entitlement policy test

johnnyshields force-pushed the es-upgrade-9.1.4 branch from 0994c0a to 0ddb019 Compare October 28, 2025 09:09

johnnyshields added 3 commits October 28, 2025 19:19

Fix loading char.def from unentitled filesystem

2b42f49

Fix plugin loading test

2cb948b

Unify config file loading

6dd1813

johnnyshields commented Oct 28, 2025

View reviewed changes

johnnyshields added 3 commits October 28, 2025 20:33

Fix config file anchoring

addb438

Load config files from the sudachi jar

4a1b634

Revert unneeded test files

da2b0c9

johnnyshields commented Oct 28, 2025

View reviewed changes

hayashi-mas-wap self-requested a review January 30, 2026 08:10

hayashi-mas-wap requested changes Jan 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade to Elasticsearch 9.1.4#174

Upgrade to Elasticsearch 9.1.4#174
johnnyshields wants to merge 8 commits intoWorksApplications:developfrom
johnnyshields:es-upgrade-9.1.4

johnnyshields commented Oct 25, 2025 •

edited

Loading

Uh oh!

johnnyshields Oct 28, 2025

Uh oh!

johnnyshields Oct 28, 2025

Uh oh!

johnnyshields Oct 28, 2025

Uh oh!

johnnyshields Oct 28, 2025

Uh oh!

johnnyshields Oct 28, 2025

Uh oh!

johnnyshields Oct 28, 2025 •

edited

Loading

Uh oh!

hayashi-mas-wap left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

johnnyshields commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnnyshields Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

johnnyshields Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

johnnyshields Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

johnnyshields Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

johnnyshields Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

johnnyshields Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hayashi-mas-wap left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

johnnyshields commented Oct 25, 2025 •

edited

Loading

johnnyshields Oct 28, 2025 •

edited

Loading