Open
Conversation
Before this, the setter function handled auto-negotiation incorrectly -- specifically it had no provision for 100FA, now correctly renamed 100HA. The getter function would also incorrectly return 100BT full-duplex for 100HA.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure there's any activity still happening in this repo, so this is more for anyone else who runs into the same PHY configuration issue.
This commit fixes the following:
PHY_MODE_AUTONEGOin thewizphy_setphyconfargument, the function would unconditionally configure the PHY for "All Modes Capable". This is not quite in line with the datasheet, which permits 100BT+HDX to be paired with Auto-Negotiation.PHYCFGR_OPMDC_100FAseems to have been misnamed all this time -- it should've been calledPHYCFGR_OPMDC_100HAsince the Auto-negotiation is paired with 100BT-HDX, not 100BT-FDX.wizphy_getphyconf, the above misnaming meant that the function would incorrectly return 100BT-FDX + Auto-nego, when the real conf is actually 100BT-HDX + Auto-Nego.