Log dispatch events by JamesPHoughton · Pull Request #1097 · Watts-Lab/deliberation-empirica

JamesPHoughton · 2025-12-08T18:34:15Z

No description provided.

LoopbackCheck was calling `ctx.close()` after the tone test and again in the effect cleanup, so if a participant advanced or retried quickly React unmounted the component and tried to close an already closed AudioContext. Added guards so we only close when the context is still open and clear the ref, eliminating the InvalidStateError and the Sentry noise.

Targets "Error when starting local audio level observer!"

Daily’s device-error events sometimes carry nested objects (e.g., `errorMsg.message`), and we were shoving that object straight into `UserMediaError`, triggering React’s “object as child” crash. Normalize the event payload in `VideoCall` by extracting a string from `errorMsg`/`error` before storing it so the fallback UI can render safely.

to make it consistent across all intro/exit steps, and play well with the stageDuration during the game

github-actions · 2025-12-08T18:34:40Z

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/Call.jsx
  40:9  warning  The 'players' logical expression could make the dependencies of useMemo Hook (at line 177) change on every render. To fix this, wrap the initialization of 'players' in its own useMemo() Hook  react-hooks/exhaustive-deps
  40:9  warning  The 'players' logical expression could make the dependencies of useMemo Hook (at line 206) change on every render. To fix this, wrap the initialization of 'players' in its own useMemo() Hook  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/UserMediaError.jsx
  60:24  error  Do not use Array index in keys  react/no-array-index-key

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/layouts/defaultResponsiveLayout.test.js
  1:32  error  'vi' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/chat/Chat.jsx
  32:7  warning  React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/ConditionalRender.jsx
  39:10  error  'tickTock' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/EmpiricaMenu.jsx
  51:3  error  React Hook "useEffect" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/IdleProvider.jsx
   56:6   warning  React Hook useEffect has a missing dependency: 'resetTimer'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  120:57  error    ''' can be escaped with '&apos;', '&lsquo;', '&#39;', '&rsquo;'                                                react/no-unescaped-entities

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  27:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/KitchenTimer.jsx
  9:10  error  'tickTock' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  54:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  61:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  135:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/AudioEquipmentCheck.jsx
   90:6   warning  React Hook useEffect has a missing dependency: 'permissionsStatus'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  114:24  error    Unnecessary return statement                                                                                          no-useless-return
  122:5   error    Arrow function expected no return value                                                                               consistent-return

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/CameraCheck.jsx
  96:6  warning  React Hook useEffect has a missing dependency: 'devices'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/GetPermissions.jsx
  191:5  error  Do not nest ternary expressions  no-nested-ternary
  231:5  error  Do not nest ternary expressions  no-nested-ternary

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/LoopbackCheck.jsx
  165:36  error  Return values from promise executor functions cannot be read  no-promise-executor-return

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/MicCheck.jsx
  88:7  error  React Hook "useCallback" is called conditionally. React Hooks must be called in the exact same order in every component render  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
   176:34  error  'actualOrder' is already declared in the upper scope on line 157 column 13  no-shadow
   203:31  error  'newOrder' is already declared in the upper scope on line 192 column 13     no-shadow
  1094:9   error  Expected an assignment or function call and instead saw an expression       no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/03_Text_Chat.js
  200:9  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  215:9  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/16_Video_Discussion_Layouts.js
  166:11  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  183:11  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  191:9   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  25:9  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
    8:33  error  Missing file extension for "./preFlight/validateTreatmentFile"  import/extensions
  327:30  error  Unexpected 'await' inside a loop                                no-await-in-loop

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  507:9  error  Unexpected use of continue statement  no-continue

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/preFlightChecks.js
  20:5  error  iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations  no-restricted-syntax

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/validateDlConfig.test.js
  2:32  error  Missing file extension for "./validateDlConfig"                                                                            import/extensions
  3:1   error  'vscode' import should occur before import of './validateDlConfig'                                                         import/order
  6:25  error  Unexpected block statement surrounding arrow body; parenthesize the returned value and move it immediately after the '=>'  arrow-body-style

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/validatePromptFile.test.js
  7:8  error  Missing file extension for "./validatePromptFile"  import/extensions

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/providers/dailyco.js
   37:23  error  Expected to return a value at the end of async function 'createRoom'     consistent-return
  157:23  error  Expected to return a value at the end of async function 'stopRecording'  consistent-return
  229:7   error  Unexpected if as the only statement in an else block                     no-lonely-if

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/utils/logging.js
  1:17  error  'warn' is defined but never used  no-unused-vars
  1:29  error  'log' is defined but never used   no-unused-vars

✖ 47 problems (38 errors, 9 warnings)
  3 errors and 0 warnings potentially fixable with the '--fix' option.

github-actions · 2025-12-09T15:01:04Z

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/Call.jsx
  40:9  warning  The 'players' logical expression could make the dependencies of useMemo Hook (at line 177) change on every render. To fix this, wrap the initialization of 'players' in its own useMemo() Hook  react-hooks/exhaustive-deps
  40:9  warning  The 'players' logical expression could make the dependencies of useMemo Hook (at line 206) change on every render. To fix this, wrap the initialization of 'players' in its own useMemo() Hook  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/UserMediaError.jsx
  113:5   error  Arrow function expected no return value  consistent-return
  153:24  error  Do not use Array index in keys           react/no-array-index-key

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/layouts/defaultResponsiveLayout.test.js
  1:32  error  'vi' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/chat/Chat.jsx
  32:7  warning  React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/ConditionalRender.jsx
  39:10  error  'tickTock' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/EmpiricaMenu.jsx
  51:3  error  React Hook "useEffect" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/IdleProvider.jsx
   56:6   warning  React Hook useEffect has a missing dependency: 'resetTimer'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  120:57  error    ''' can be escaped with '&apos;', '&lsquo;', '&#39;', '&rsquo;'                                                react/no-unescaped-entities

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  27:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/KitchenTimer.jsx
  9:10  error  'tickTock' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  54:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  8:26  error  Unexpected function expression  prefer-arrow-callback

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  61:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  135:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/AudioEquipmentCheck.jsx
   90:6   warning  React Hook useEffect has a missing dependency: 'permissionsStatus'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  114:24  error    Unnecessary return statement                                                                                          no-useless-return
  122:5   error    Arrow function expected no return value                                                                               consistent-return

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/CameraCheck.jsx
  96:6  warning  React Hook useEffect has a missing dependency: 'devices'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/GetPermissions.jsx
  191:5  error  Do not nest ternary expressions  no-nested-ternary
  231:5  error  Do not nest ternary expressions  no-nested-ternary

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/LoopbackCheck.jsx
  165:36  error  Return values from promise executor functions cannot be read  no-promise-executor-return

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/MicCheck.jsx
  88:7  error  React Hook "useCallback" is called conditionally. React Hooks must be called in the exact same order in every component render  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
   176:34  error  'actualOrder' is already declared in the upper scope on line 157 column 13  no-shadow
   203:31  error  'newOrder' is already declared in the upper scope on line 192 column 13     no-shadow
  1094:9   error  Expected an assignment or function call and instead saw an expression       no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/03_Text_Chat.js
  200:9  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  215:9  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/16_Video_Discussion_Layouts.js
  162:11  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  179:11  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  187:9   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  25:9  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
    8:33  error  Missing file extension for "./preFlight/validateTreatmentFile"  import/extensions
  327:30  error  Unexpected 'await' inside a loop                                no-await-in-loop

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  507:9  error  Unexpected use of continue statement  no-continue

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/preFlightChecks.js
  20:5  error  iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations  no-restricted-syntax

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/validateDlConfig.test.js
  2:32  error  Missing file extension for "./validateDlConfig"                                                                            import/extensions
  3:1   error  'vscode' import should occur before import of './validateDlConfig'                                                         import/order
  6:25  error  Unexpected block statement surrounding arrow body; parenthesize the returned value and move it immediately after the '=>'  arrow-body-style

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/validatePromptFile.test.js
  7:8  error  Missing file extension for "./validatePromptFile"  import/extensions

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/providers/dailyco.js
   37:23  error  Expected to return a value at the end of async function 'createRoom'     consistent-return
  157:23  error  Expected to return a value at the end of async function 'stopRecording'  consistent-return
  229:7   error  Unexpected if as the only statement in an else block                     no-lonely-if

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/utils/logging.js
  1:17  error  'warn' is defined but never used  no-unused-vars
  1:29  error  'log' is defined but never used   no-unused-vars

✖ 49 problems (40 errors, 9 warnings)
  4 errors and 0 warnings potentially fixable with the '--fix' option.

cypress · 2025-12-09T15:07:24Z

Deliberation Run #1883

Run Properties: Failed #1883 • a61912921b: update dispatch

Project	`Deliberation`
Branch Review	`james/update-equipment-checks`
Run status	`Failed #1883`
Run duration	`05m 54s`
Commit	`a61912921b: update dispatch`
Committer	`James Houghton`
View all properties for this run ↗︎

Test results
Failures	`13`
Flaky	`0`
Pending	`1`
Skipped	`0`
Passing	`5`
View all changes introduced in this branch ↗︎

Tests for review

01_Normal_Paths_Omnibus.js • 1 failed test • CI RUN

View Output

Test		Artifacts
Multiplayer Normal Paths Omnibus > walks properly		`Test Replay` `Screenshots`

15_Lobby_Dispatch_Conditions.js • 1 failed test • CI RUN

View Output

Test		Artifacts
Lobby dispatch conditions > delays assignment until two dispatch events occur		`Test Replay` `Screenshots`

09_Many_Players.js • 1 failed test • CI RUN

View Output

Test		Artifacts
Load test > the crowd goes wild		`Test Replay` `Screenshots`

06_Many_Games.js • 1 failed test • CI RUN

View Output

Test		Artifacts
Many Games > handles game creation properly		`Test Replay` `Screenshots`

13_Constrained_Assignment.js • 1 failed test • CI RUN

View Output

Test		Artifacts
Constrained Assignment > assigns players to the correct games		`Test Replay` `Screenshots`

The first 5 failed specs are shown, see all 12 specs in Cypress Cloud.

github-actions · 2025-12-12T17:55:18Z

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/Call.jsx
  40:9  warning  The 'players' logical expression could make the dependencies of useMemo Hook (at line 177) change on every render. To fix this, wrap the initialization of 'players' in its own useMemo() Hook  react-hooks/exhaustive-deps
  40:9  warning  The 'players' logical expression could make the dependencies of useMemo Hook (at line 206) change on every render. To fix this, wrap the initialization of 'players' in its own useMemo() Hook  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/UserMediaError.jsx
  113:5   error  Arrow function expected no return value  consistent-return
  153:24  error  Do not use Array index in keys           react/no-array-index-key

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/call/layouts/defaultResponsiveLayout.test.js
  1:32  error  'vi' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/chat/Chat.jsx
  32:7  warning  React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/ConditionalRender.jsx
  39:10  error  'tickTock' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/EmpiricaMenu.jsx
  51:3  error  React Hook "useEffect" is called conditionally. React Hooks must be called in the exact same order in every component render. Did you accidentally call a React Hook after an early return?  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/IdleProvider.jsx
   56:6   warning  React Hook useEffect has a missing dependency: 'resetTimer'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  120:57  error    ''' can be escaped with '&apos;', '&lsquo;', '&#39;', '&rsquo;'                                                react/no-unescaped-entities

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/Markdown.jsx
  17:6  error  Unnecessary escape character: !  no-useless-escape

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/components/SharedNotepad.jsx
  27:6  warning  React Hook useEffect has missing dependencies: 'defaultText', 'game', and 'record'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/KitchenTimer.jsx
  9:10  error  'tickTock' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Qualtrics.jsx
  54:10  error  'state' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/Survey.jsx
  8:26  error  Unexpected function expression  prefer-arrow-callback

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/elements/TrainingVideo.jsx
  61:6  warning  React Hook useEffect has missing dependencies: 'timer?.elapsed' and 'url'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Consent.jsx
  135:6  warning  React Hook useEffect has a missing dependency: 'player'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/Countdown.jsx
  8:21  error  Use default import syntax to import 'ReactCountdown'  import/no-named-default

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/AudioEquipmentCheck.jsx
   90:6   warning  React Hook useEffect has a missing dependency: 'permissionsStatus'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  114:24  error    Unnecessary return statement                                                                                          no-useless-return
  122:5   error    Arrow function expected no return value                                                                               consistent-return

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/CameraCheck.jsx
  96:6  warning  React Hook useEffect has a missing dependency: 'devices'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/GetPermissions.jsx
  191:5  error  Do not nest ternary expressions  no-nested-ternary
  231:5  error  Do not nest ternary expressions  no-nested-ternary

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/LoopbackCheck.jsx
  165:36  error  Return values from promise executor functions cannot be read  no-promise-executor-return

/home/runner/work/deliberation-empirica/deliberation-empirica/client/src/intro-exit/setup/MicCheck.jsx
  88:7  error  React Hook "useCallback" is called conditionally. React Hooks must be called in the exact same order in every component render  react-hooks/rules-of-hooks

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/01_Normal_Paths_Omnibus.js
   176:34  error  'actualOrder' is already declared in the upper scope on line 157 column 13  no-shadow
   203:31  error  'newOrder' is already declared in the upper scope on line 192 column 13     no-shadow
  1094:9   error  Expected an assignment or function call and instead saw an expression       no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/03_Text_Chat.js
  200:9  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  215:9  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/e2e/16_Video_Discussion_Layouts.js
  162:11  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  179:11  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions
  187:9   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions

/home/runner/work/deliberation-empirica/deliberation-empirica/cypress/support/sharedSteps.js
  25:9  error  'log' is assigned a value but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/getTreatments.js
    8:33  error  Missing file extension for "./preFlight/validateTreatmentFile"  import/extensions
  327:30  error  Unexpected 'await' inside a loop                                no-await-in-loop

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/index.js
  42:43  error  'p' is defined but never used  no-unused-vars

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/dispatch.js
  508:9  error  Unexpected use of continue statement  no-continue

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/preFlightChecks.js
  20:5  error  iterators/generators require regenerator-runtime, which is too heavyweight for this guide to allow them. Separately, loops should be avoided in favor of array iterations  no-restricted-syntax

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/validateDlConfig.test.js
  2:32  error  Missing file extension for "./validateDlConfig"                                                                            import/extensions
  3:1   error  'vscode' import should occur before import of './validateDlConfig'                                                         import/order
  6:25  error  Unexpected block statement surrounding arrow body; parenthesize the returned value and move it immediately after the '=>'  arrow-body-style

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/preFlight/validatePromptFile.test.js
  7:8  error  Missing file extension for "./validatePromptFile"  import/extensions

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/providers/dailyco.js
   37:23  error  Expected to return a value at the end of async function 'createRoom'     consistent-return
  157:23  error  Expected to return a value at the end of async function 'stopRecording'  consistent-return
  229:7   error  Unexpected if as the only statement in an else block                     no-lonely-if

/home/runner/work/deliberation-empirica/deliberation-empirica/server/src/utils/logging.js
  1:17  error  'warn' is defined but never used  no-unused-vars
  1:29  error  'log' is defined but never used   no-unused-vars

✖ 49 problems (40 errors, 9 warnings)
  4 errors and 0 warnings potentially fixable with the '--fix' option.

JamesPHoughton added 17 commits November 14, 2025 16:13

Rework mic check and headphones check

ee8d519

update cypress tests

e283215

working on solo room message

f3f41de

fix solo room message

5ca80f9

Update Call.jsx

57d35a6

split audio and video checks

5d1b669

update tests

3054309

Merge branch 'main' into james/update-equipment-checks

cbaf3f3

Update MicCheck.jsx

c3f67ca

Targets "Error when starting local audio level observer!"

Add error handling to loopback check

80e62bd

Merge branch 'main' into james/update-equipment-checks

e78a79d

Update 01_Normal_Paths_Omnibus.js

3aa156d

Refactor elapsed time logic

b74ee2d

to make it consistent across all intro/exit steps, and play well with the stageDuration during the game

log lobby time

ba61672

WIP dispatch off-by-one

f1be97d

Merge branch 'main' into james/update-equipment-checks

d6219cc

update dispatch

a619129

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Log dispatch events#1097

Log dispatch events#1097
JamesPHoughton wants to merge 19 commits intomainfrom
james/update-equipment-checks

JamesPHoughton commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

cypress bot commented Dec 9, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

JamesPHoughton commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 8, 2025

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

cypress bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deliberation Run #1883

Tests for review

Uh oh!

github-actions bot commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

cypress bot commented Dec 9, 2025 •

edited

Loading