Conversation
📝 WalkthroughWalkthroughThis PR restructures relic data storage by moving Eterna tier relic definitions from an undefined location to the Requiem tier while updating the parser to recognize the new "Eterna." variant. A timestamp is updated in the metadata file. ChangesRelic Data Reorganization
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/utils.js`:
- Around line 367-373: The relic regex in parseRelic is too permissive and
allows empty captures; tighten relicRegex by replacing the name and roman
numeral groups with required character repeats (use ([A-Za-z]+) instead of
([A-z]*) and ([IVXLCDM]+) instead of ([IVXLCDM]*)) and require the space before
"Relic" (use \sRelic\s instead of \s?Relic\s) so malformed strings like "Requiem
Relic (Intact)" no longer match; update the regex variable relicRegex
accordingly in lib/utils.js (the parseRelic matching block) and add a unit test
asserting parseRelic("Requiem Relic (Intact)") returns undefined.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5642f9ef-20e5-4d1c-a37a-d05792aeb1c9
📒 Files selected for processing (9)
data/all.jsondata/all.slim.jsondata/builds/f5487c5af8f62fd5f1a53576e9d0fc57.jsondata/info.jsondata/relics.jsondata/relics/Eterna/undefined.jsondata/relics/Requiem/ETERNA.jsondata/syndicates.jsonlib/utils.js
💤 Files with no reviewable changes (1)
- data/relics/Eterna/undefined.json
Warframe Drop Data Site Pull Request
What I did:
I added
Eternato the the relic regexWhy I did it:
Requiem Eternawere being treated as a relic tier instead of being nested underRequiemFixes issue (include link):
Doesn't fix any open issue, just something I noticed looking through it
Mockups, screenshots, evidence:
Was this an issue fix or a suggestion fulfillment?
Summary by CodeRabbit
Release Notes
Refactor
Data Updates