Skip to content

fix: parsing Requiem Eterna being treated as relic tier instead of Requiem#96

Merged
TobiTenno merged 3 commits intoWFCD:mainfrom
SlayerOrnstein:requiem-eterna
May 7, 2026
Merged

fix: parsing Requiem Eterna being treated as relic tier instead of Requiem#96
TobiTenno merged 3 commits intoWFCD:mainfrom
SlayerOrnstein:requiem-eterna

Conversation

@SlayerOrnstein
Copy link
Copy Markdown
Member

@SlayerOrnstein SlayerOrnstein commented May 6, 2026

Warframe Drop Data Site Pull Request


What I did:
I added Eterna to the the relic regex


Why I did it:
Requiem Eterna were being treated as a relic tier instead of being nested under Requiem


Fixes issue (include link):
Doesn't fix any open issue, just something I noticed looking through it


Mockups, screenshots, evidence:


Was this an issue fix or a suggestion fulfillment?

Summary by CodeRabbit

Release Notes

  • Refactor

    • Reorganized relic data structure and updated the relic system to support additional tier and variant classifications.
  • Data Updates

    • Updated relic reward definitions with new tier variants and reward configurations.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

📝 Walkthrough

Walkthrough

This PR restructures relic data storage by moving Eterna tier relic definitions from an undefined location to the Requiem tier while updating the parser to recognize the new "Eterna." variant. A timestamp is updated in the metadata file.

Changes

Relic Data Reorganization

Layer / File(s) Summary
Data Migration
data/relics/Eterna/undefined.json, data/relics/Requiem/ETERNA.json
Relic reward data (8 Intact Rare items) moved from the Eterna/undefined location to Requiem/ETERNA tier structure.
Parser Update
lib/utils.js
parseRelic function extended with additional regex capture group to recognize the "Eterna." relic variant, deriving relicName from expanded match groups and state from new capture index.
Metadata
data/info.json
Timestamp value updated to reflect changes.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested Reviewers

  • TobiTenno

Poem

🐰 A relic once lost in the undefined haze,
Now rests in Requiem's well-ordered ways,
The parser learns new names to trace,
Each Eterna variant finds its place.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main fix: correcting how 'Requiem Eterna' is parsed to be treated as part of Requiem instead of a separate relic tier.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/utils.js`:
- Around line 367-373: The relic regex in parseRelic is too permissive and
allows empty captures; tighten relicRegex by replacing the name and roman
numeral groups with required character repeats (use ([A-Za-z]+) instead of
([A-z]*) and ([IVXLCDM]+) instead of ([IVXLCDM]*)) and require the space before
"Relic" (use \sRelic\s instead of \s?Relic\s) so malformed strings like "Requiem
Relic (Intact)" no longer match; update the regex variable relicRegex
accordingly in lib/utils.js (the parseRelic matching block) and add a unit test
asserting parseRelic("Requiem Relic (Intact)") returns undefined.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5642f9ef-20e5-4d1c-a37a-d05792aeb1c9

📥 Commits

Reviewing files that changed from the base of the PR and between c7639a6 and f9b781c.

📒 Files selected for processing (9)
  • data/all.json
  • data/all.slim.json
  • data/builds/f5487c5af8f62fd5f1a53576e9d0fc57.json
  • data/info.json
  • data/relics.json
  • data/relics/Eterna/undefined.json
  • data/relics/Requiem/ETERNA.json
  • data/syndicates.json
  • lib/utils.js
💤 Files with no reviewable changes (1)
  • data/relics/Eterna/undefined.json

Comment thread lib/utils.js
@TobiTenno TobiTenno merged commit 97038bc into WFCD:main May 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants