Feat/delta simplify cancel and withdraw#235
Open
andriy-shymkiv wants to merge 2 commits intomasterfrom
Open
Conversation
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified
cancelAndWithdrawfollowing the changes on the contracts sidecloses FRNT-1310
Note
Medium Risk
Changes the on-chain
cancelAndWithdrawcall signature and ABI encoding, which can break cancellations/withdrawals if client and deployed contract versions diverge.Overview
Simplifies Delta
cancelAndWithdrawto align with the updated contract ABI by removing thesignature/OrderWithSigwrapper (and the unusedbridgeOverride/cosignaturedefaults) and sending a sanitizedOrderstruct directly.Updates the local ABI definition accordingly and drops the now-unused
DEFAULT_BRIDGEdependency.Reviewed by Cursor Bugbot for commit 004f0f7. Bugbot is set up for automated code reviews on this repo. Configure here.