fix:[#476] return error code on stack delete failure#489
Merged
NN708 merged 2 commits intoVanilla-OS:mainfrom Mar 13, 2026
Merged
fix:[#476] return error code on stack delete failure#489NN708 merged 2 commits intoVanilla-OS:mainfrom
NN708 merged 2 commits intoVanilla-OS:mainfrom
Conversation
mirkobrombin
approved these changes
Mar 12, 2026
NN708
requested changes
Mar 12, 2026
Co-authored-by: NN708 <yuqian_1998@126.com>
NN708
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly returns an error when attempting to delete a stack that is currently used by subsystems.
Note: there are similar places in this source file where there are logged errors but a
return nil. Not sure if those should also be looked at but may lead to similar issues in the future.Closes: #476