[TF2] fix miniguns having inconsistent spin-down time based on which mouse button is released#1744
Open
wgetJane wants to merge 1 commit intoValveSoftware:masterfrom
Open
[TF2] fix miniguns having inconsistent spin-down time based on which mouse button is released#1744wgetJane wants to merge 1 commit intoValveSoftware:masterfrom
wgetJane wants to merge 1 commit intoValveSoftware:masterfrom
Conversation
…button is released
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
when you unrev the minigun by releasing your left mouse button, it takes ~1.15 secs to fully spin down
when you unrev the minigun by releasing your right mouse button, it takes ~1.44 secs to fully spin down
this is because when
SendWeaponAnim( ACT_VM_SECONDARYATTACK )is used to set the weapon's idle rev animation, it also inadvertently changes the weapon's "idle time" as a side effect which adds a delay:source-sdk-2013/src/game/shared/basecombatweapon_shared.cpp
Line 2425 in 7191ecc
unfixed:
spindown_unfixed.mp4
fixed:
spindown_fixed.mp4
note: green crosshair = no mouse buttons pressed