fix(OnboardingTooltip): fix flaky tests#9608
Open
EldarMuhamethanov wants to merge 1 commit intomasterfrom
Open
fix(OnboardingTooltip): fix flaky tests#9608EldarMuhamethanov wants to merge 1 commit intomasterfrom
EldarMuhamethanov wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
ci:cherry-pick:patch
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9608/310125a24250efa5af1b434f5f068999657497bd/pkg/@vkontakte/vkui/_pkg.tgzCommit 310125a |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9608 +/- ##
==========================================
+ Coverage 94.77% 95.42% +0.64%
==========================================
Files 440 440
Lines 11954 12077 +123
Branches 4407 4364 -43
==========================================
+ Hits 11330 11524 +194
+ Misses 624 553 -71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SevereCloud
approved these changes
Mar 19, 2026
inomdzhon
removed
the
ci:cherry-pick:patch
Contributor
|
может закатим уже в |
vkcom-publisher
added
pr-needs-work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Попытка поправить флакающий скриншотный e2e-тест
OnboardingTooltipиз‑за промежуточного/устаревшего позиционирования floating-ui при рендерах/изменениях размеров.Изменения
OnboardingTooltip: скрываем тултип черезvisibility: hiddenдо первого успешного позиционирования (isPositioned), чтобы исключить кадр с координатами по умолчанию.OnboardingTooltip: включилиelementResizeвautoUpdateFloatingElement, чтобы позиция пересчитывалась при изменении размеров reference/floating (в т.ч. при догрузке шрифтов, что скорее всего и являлось проблемой).screenshotWithClipToContent: послеpage.setViewportSize()ждёмrequestAnimationFrame, чтобы дать браузеру и React применить перерасчёты позиций перед снятием скриншота.Release notes