Draft
Conversation
Implement frontend support for dataset-agnostic gene/item display with
configurable highlight and subset modes:
- Update EdaDatasetGraph to use displaySpecVariableId from model config
instead of hardcoded 'VAR_bdc8e679'
- Add displayMode support ('highlight' or 'subset') to control whether
to show all data with highlighting vs. only selected items
- Rename highlightSpec to geneDisplaySpec throughout for clarity
- Add conditional rendering for bar plots vs scatter plots based on
plotType from model
- Create new EdaBarPlot component with same mode-based filtering
- Update EdaScatterPlot to implement mode-based filtering:
* 'highlight' mode: fetch all data, highlight specific genes
* 'subset' mode: filter data to show only specific genes
This makes EDA graphs work generically across all dataset types
(phenotype, cellular localization, antibody arrays, etc.) without
hardcoded variable IDs.
Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Member
Author
|
This is a WIP. see the md file for details of what was done. The Barplot.tsx needs some better eyes on it |
Member
Author
|
this is related to VEuPathDB/ApiCommonModel#146 |
Member
|
I haven't forgotten these PRs! Hope to get to them tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes EDA graphs work generically across all dataset types (phenotype, cellular localization, antibody arrays, etc.) without hardcoded variable IDs. Optional highlight vs subsetting; Scatterplot or Barplot