Skip to content

Make 8.5 the main PHP version #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
W0rma wants to merge 2 commits into from
Closed

Make 8.5 the main PHP version #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
76b6189
chore: make 8.5 the main php version
W0rma Dec 19, 2025
c147c02
chore: fix noop calls of setAccessible() which are deprecated in php 8.5
W0rma Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.4
php-version: 8.5
- name: Checkout Code
uses: actions/checkout@v2
with:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.4'
php-version: '8.5'
- name: Extract Version Name
id: extract_name
uses: actions/github-script@v7
Expand All @@ -32,17 +32,17 @@ jobs:
- name: Create latest release tag
env:
VERSION: ${{ steps.extract_name.outputs.result }}
run: git tag v${VERSION}84
run: git tag v${VERSION}85
- name: Push latest release tag
env:
VERSION: ${{ steps.extract_name.outputs.result }}
run: git push origin v${VERSION}84
run: git push origin v${VERSION}85
release_older:
name: Release older PHP version
runs-on: ubuntu-latest
strategy:
matrix:
version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
steps:
- name: Extract Version Name
id: extract_name
Expand All @@ -54,7 +54,7 @@ jobs:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.4
php-version: 8.5
- name: Checkout Code
uses: actions/checkout@v4
- name: Install Dependencies
Expand All @@ -69,7 +69,7 @@ jobs:
if: matrix.version == '7.2'
run: composer require symfony/polyfill-php73:^1.0
- name: Update composer.json version
run: 'sed -i -e ''s/"php": "\^8.4"/"php": "\^${{ matrix.version }}"/'' composer.json'
run: 'sed -i -e ''s/"php": "\^8.5"/"php": "\^${{ matrix.version }}"/'' composer.json'
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sed pattern replacement expects the composer.json to contain "php": "^8.5", but since PHP 8.5 doesn't exist, this will cause issues. The pattern should match the actual PHP version in composer.json.

Copilot uses AI. Check for mistakes.
- name: Downgrade phpunit
if: matrix.version == '7.2'
run: 'sed -i -e ''s/"phpunit\/phpunit": "\^9.5"/"phpunit\/phpunit": "\^8.5"/'' composer.json'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests-8.x.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
version: ['8.0', '8.1', '8.2', '8.3']
version: ['8.0', '8.1', '8.2', '8.3', '8.4']
steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Tests (8.4)
name: Tests (8.5)
on:
push:
branches:
Expand All @@ -14,7 +14,7 @@ jobs:
PHP_CS_FIXER_IGNORE_ENV: 1
strategy:
matrix:
version: ['8.4']
version: ['8.5']
steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand All @@ -31,7 +31,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
version: ['8.4']
version: ['8.5']
steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand All @@ -48,7 +48,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
version: ['8.4']
version: ['8.5']
optional-deps: ['', 'cache/filesystem-adapter:^1.1']
steps:
- name: Setup PHP
Expand All @@ -73,12 +73,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
steps:
- name: Setup Build PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.4
php-version: 8.5
- name: Checkout Code
uses: actions/checkout@v4
with:
Expand All @@ -91,7 +91,7 @@ jobs:
if: matrix.version == '7.2'
run: composer require symfony/polyfill-php73:^1.0
- name: Update composer.json version
run: 'sed -i -e ''s/"php": "\^8.4"/"php": "\^${{ matrix.version }}"/'' composer.json'
run: 'sed -i -e ''s/"php": "\^8.5"/"php": "\^${{ matrix.version }}"/'' composer.json'
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sed pattern replacement expects the composer.json to contain "php": "^8.5", but since PHP 8.5 doesn't exist, this will cause issues. The pattern should match the actual PHP version in composer.json.

Suggested change
run: 'sed -i -e ''s/"php": "\^8.5"/"php": "\^${{ matrix.version }}"/'' composer.json'
run: 'sed -i -e ''s/"php": "[^"]*"/"php": "\^${{ matrix.version }}"/'' composer.json'

Copilot uses AI. Check for mistakes.
- name: Downgrade phpunit
if: matrix.version == '7.2'
run: 'sed -i -e ''s/"phpunit\/phpunit": "\^9.5"/"phpunit\/phpunit": "\^8.5"/'' composer.json'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/transpile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3']
version: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4' ]
steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.4
php-version: 8.5
- name: Checkout Code
uses: actions/checkout@v4
- name: Install Dependencies
Expand All @@ -27,7 +27,7 @@ jobs:
if: matrix.version == '7.2'
run: composer require symfony/polyfill-php73:^1.0
- name: Update composer.json version
run: 'sed -i -e ''s/"php": "\^8.4"/"php": "\^${{ matrix.version }}"/'' composer.json'
run: 'sed -i -e ''s/"php": "\^8.5"/"php": "\^${{ matrix.version }}"/'' composer.json'
Copy link

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sed pattern replacement expects the composer.json to contain "php": "^8.5", but since PHP 8.5 doesn't exist, this will cause issues. The pattern should match the actual PHP version in composer.json.

Copilot uses AI. Check for mistakes.
- name: Downgrade phpunit
if: matrix.version == '7.2'
run: 'sed -i -e ''s/"phpunit\/phpunit": "\^9.5"/"phpunit\/phpunit": "\^8.5"/'' composer.json'
Expand Down
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
],
"minimum-stability": "stable",
"require": {
"php": "^8.4",
"php": "^8.5",
"ext-json": "*",
"psr/http-client": "^1.0",
"psr/http-client-implementation": "^1.0",
Expand Down
10 changes: 10 additions & 0 deletions rector.84.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?php

use Rector\Config\RectorConfig;
use Rector\Set\ValueObject\DowngradeLevelSetList;

return static function (RectorConfig $config): void {
$config->sets([
DowngradeLevelSetList::DOWN_TO_PHP_84,
]);
};
1 change: 1 addition & 0 deletions rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,6 @@
SetList::PHP_82,
SetList::PHP_83,
SetList::PHP_84,
SetList::PHP_85,
]);
};
8 changes: 6 additions & 2 deletions tests/Helper/NetworkCalculatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ private function getIpAddress(NetworkCalculator $calculator): string
{
$reflection = new ReflectionObject($calculator);
$property = $reflection->getProperty('ipAddress');
$property->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$property->setAccessible(true);
}

return $property->getValue($calculator);
}
Expand All @@ -86,7 +88,9 @@ private function getNetworkSize(NetworkCalculator $calculator): int
{
$reflection = new ReflectionObject($calculator);
$property = $reflection->getProperty('networkSize');
$property->setAccessible(true);
if (PHP_VERSION_ID < 80100) {
$property->setAccessible(true);
}

return $property->getValue($calculator);
}
Expand Down
Loading
Loading