feat(development-pr-workflow): rewrite resolve-pr-issues as orchestration pipeline#410
feat(development-pr-workflow): rewrite resolve-pr-issues as orchestration pipeline#410
Conversation
…tion pipeline Redesign the resolve-pr-issues skill from a loose reference guide into a structured 7-phase orchestration workflow that: - Fetches all PR feedback: inline comments, review bodies (via gh api), and CI status in parallel - Normalizes feedback into a unified item list with blocking classification, resolved/outdated detection, and CI bot deduplication - Triages each item (ACTION_REQUIRED → subagent, RESPOND_ONLY → post reply, NO_ACTION → skip) using an explicit decision tree - Dispatches comment-resolver-agent subagents per file group for code changes - Posts substantive replies for items that don't need code changes - Detects project tooling before running verification - Asks user before committing Also adds: - New comment-resolver-agent for per-file comment resolution - Updated pr-guide.md with triage framework, reply protocol, and CI handling - Plugin version bump 2.0.1 → 2.1.0
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🤖 Claude Code Review
PR #410 Review — Add
|
📚 Documentation Check ✅Verdict: Passed All required documentation is properly updated: plugin version bumped from 2.0.1 to 2.1.0 (minor bump for new agent), root CLAUDE.md version table updated, plugin CLAUDE.md updated with new agent documentation and file structure, README.md updated with new agent in agents table, and plugin.json properly references the new comment-resolver agent. PR #410 Documentation ReviewSummaryPR #410 adds a new Checks Performed
No Issues FoundAll internal documentation is synchronized with the code changes. The PR correctly follows semver (minor bump for backward-compatible new feature), updates all relevant documentation layers, and properly registers the new agent in plugin.json. ✨ No Documentation Updates NeededAll documentation appears to be up to date with the code changes. 🤖 Generated by Claude Documentation Validator | Mode: |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only. 2 inline comment(s) are attached below.
packages/plugins/development-pr-workflow/agents/comment-resolver.md
Outdated
Show resolved
Hide resolved
packages/plugins/development-pr-workflow/skills/resolve-pr-issues/SKILL.md
Outdated
Show resolved
Hide resolved
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7edff7e731
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/plugins/development-pr-workflow/skills/resolve-pr-issues/SKILL.md
Show resolved
Hide resolved
packages/plugins/development-pr-workflow/skills/resolve-pr-issues/SKILL.md
Show resolved
Hide resolved
- Add cross-agent file conflict detection in Phase 5 — orchestrator compares modified file lists from parallel agents and re-runs sequentially if overlaps detected - Fix verification --base flag to use PR base branch (origin/next) instead of HEAD to match CI behavior - Fix CI bot dedup to preserve CI failures when inline bot comment is stale/resolved - Update comment-resolver-agent to emphasize reporting all modified files for conflict detection
github-actions
bot
dismissed
their stale review
Superseded by new review after PR update
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only.
The docs-check bot flagged that the new comment-resolver-agent was missing from the README Agents table despite being in plugin.json and CLAUDE.md.
…esolve-pr-issues - Reorder agents table in README to match plugin.json order - Expand MCP tool prefixes in SKILL.md allowed-tools (support both plugin namespaces) - Add merged/closed PR state warning to Phase 0 validation - Clarify changed files list purpose in Phase 1 gather table - Differentiate error handling tiers (inline stop-and-surface vs CI continue-with-note) - Add "security"/"vulnerability" blocking overrides and "minor"/"nice to have" non-blocking - Add rule 6 for ambiguous bug concerns (RESPOND_ONLY with user-review flag) - Batch unlocated review body items (up to 3 per agent) and cap CI failure agents at 3 - Fix gh api reply commands to use mktemp + -F body=@file to prevent shell injection - Align pr-guide.md dispatch table and decision tree with SKILL.md - Remove redundant local verification section from pr-guide.md (pointer in SKILL.md)
development-pr-workflow bumped to 2.1.0 on this branch (orchestration rewrite); development-productivity bumped to 2.1.1 on next (generate-document skill). Keep both version updates.
github-actions
bot
dismissed
their stale review
Superseded by new review after PR update
There was a problem hiding this comment.
📋 Review verdict: APPROVE
👆 The main review comment above is the source of truth for this PR review. It is automatically updated on each review cycle, so always refer to it for the most current feedback.
This formal review submission is for the verdict only.
1 participant
Summary
resolve-pr-issuesskill from a loose reference guide into a structured 7-phase orchestration pipeline with explicit triage-then-dispatch for all PR feedback (inline comments, review bodies, CI failures)comment-resolver-agentfor per-file-group comment resolution via subagent dispatchpr-guide.mdwith triage decision framework, reply protocol, blocking classification, and CI handling reference2.0.1→2.1.0Changes
New:
agents/comment-resolver.mdPer-file agent that receives triaged
ACTION_REQUIREDcomments and applies code changes. Handles CI failures (can run commands, not just edit files). Supports cross-file changes when a comment requires it. Does NOT commit or post replies — the orchestrator handles those.Rewritten:
skills/resolve-pr-issues/SKILL.mdNew 7-phase workflow:
gh api), CI status, diffACTION_REQUIRED→ subagent,RESPOND_ONLY→ post reply,NO_ACTION→ skipcomment-resolver-agentper group; post replies forRESPOND_ONLYitems directlyKey improvements over previous version:
RESPOND_ONLYitems get substantive replies instead of being silently skippedRewritten:
skills/resolve-pr-issues/pr-guide.mdComplete restructure to support new workflow. Adds: triage decision framework with examples, blocking classification rules with language overrides, review body parsing guidance, CI bot deduplication rules, subagent dispatch reference, reply protocol with templates, unified CI handling, phase-specific error handling table.
Modified:
.claude-plugin/plugin.jsonAdded
./agents/comment-resolver.mdto agents array. Version bump2.0.1→2.1.0.Modified: Plugin
CLAUDE.mdand rootCLAUDE.mdUpdated component lists and version table.
Backward Compatibility
review-executor.mdagent is unchanged —resolve-all-prscontinues to work as beforeresolve-all-prsskill is unchangedTest plan
node scripts/validate-plugin.cjs packages/plugins/development-pr-workflow— validates plugin structurenpm exec markdownlint-cli2 -- --fixon changed files — validates markdown/resolve-pr-issueson a real PR with inline comments and review bodyresolve-all-prsstill works (backward compat)✨ Claude-Generated Content
Summary
resolve-pr-issuesskill from a loose reference guide into a structured 7-phase orchestration pipeline with explicit triage-then-dispatch for all PR feedback (inline comments, review bodies, CI failures)comment-resolver-agentfor per-file-group comment resolution via subagent dispatchpr-guide.mdwith triage decision framework, reply protocol, blocking classification, and CI handling reference2.0.1→2.1.0Changes
agents/comment-resolver.mdACTION_REQUIREDcomments per file group, applies code changes, handles CI failures (can run commands), supports cross-file changes. Does NOT commit or post replies — the orchestrator handles thoseskills/resolve-pr-issues/SKILL.mdskills/resolve-pr-issues/pr-guide.md.claude-plugin/plugin.json./agents/comment-resolver.mdto agents array; version bump2.0.1→2.1.0CLAUDE.mdCLAUDE.mddevelopment-pr-workflowKey Improvements Over Previous Version
RESPOND_ONLYitems get substantive replies instead of being silently skippedBackward Compatibility
review-executor.mdagent is unchanged —resolve-all-prscontinues to work as beforeresolve-all-prsskill is unchangedTest plan
node scripts/validate-plugin.cjs packages/plugins/development-pr-workflow— validates plugin structurenpm exec markdownlint-cli2 -- --fixon changed files — validates markdown/resolve-pr-issueson a real PR with inline comments and review bodyresolve-all-prsstill works (backward compat)