-
Notifications
You must be signed in to change notification settings - Fork 3
fix(plugins): remove skill symlink workaround now that issue #17271 is fixed #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…s fixed Claude Code v2.1.29 fixed the bug where plugin skills didn't appear in slash command autocomplete. This removes the workaround that was needed: - Remove all 29 SKILL.md symlinks, rename <skillname>.md to SKILL.md - Remove skill entries from commands arrays in all 8 plugin.json files (keep 6 standalone commands in dev-pr-workflow and dev-productivity) - Update documentation to reflect the clean approach - Fix stale Glob reference in execute-plan agent - Patch bump all 8 plugin versions
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🤖 Claude Code Review
Claude Code Review has been skipped for this PR because the diff is too large. Large PRs are harder to review thoroughly and increase the risk of bugs slipping through. Recommendations:
Once you've split this into smaller PRs, Claude will be able to provide detailed automated reviews for each one. 💡 Want a fresh review? Add a comment containing |
📚 Documentation Check ✅Verdict: Passed All required documentation is present. Plugin versions were properly bumped for all 8 affected plugins, and documentation was updated to reflect the removal of the symlink workaround. Documentation Review: PR #386OverviewThis PR removes the symlink workaround for user-invocable skills across all plugins, simplifying the plugin architecture. The changes are comprehensive and properly documented. ✅ Version Bumps - All CorrectAll 8 plugins that were modified have been properly version-bumped:
Rationale: Patch bumps are appropriate because this is an internal structural change (symlinks → direct files) with no user-facing functional changes. ✅ Documentation UpdatesRoot CLAUDE.md
Plugin-Level CLAUDE.md Files
plugin.json ChangesAll plugins correctly:
✅ Structural ChangesFor each affected plugin skill:
Example transformation for Changes SummaryAffected Skills (20 total)
ConclusionThis PR properly:
No additional documentation updates are required. ✨ No Documentation Updates NeededAll documentation appears to be up to date with the code changes. 🤖 Generated by Claude Documentation Validator | Mode: |
Summary
Removes the skill symlink workaround from all 29 skills across 8 plugins, now that Claude Code v2.1.29 has fixed anthropics/claude-code#17271 (plugin skills not appearing in slash command autocomplete).
SKILL.mdsymlinks, rename<skillname>.md→SKILL.mdcommandsarrays in all 8plugin.jsonfiles (6 standalone commands preserved)execute-planagent that would have broken at runtimeContext
The workaround involved renaming
SKILL.mdto<skillname>.md, creating symlinks, and adding skills to bothskillsandcommandsarrays inplugin.json. With the fix, skills just need aSKILL.mdfile and an entry in theskillsarray.Confirmed working by this comment.
Test plan
commandsarraysvalidate-plugin.cjs✨ Claude-Generated Content
Summary
Removes the skill symlink workaround from all 29 skills across 8 plugins, now that Claude Code v2.1.29 has fixed anthropics/claude-code#17271 (plugin skills not appearing in slash command autocomplete).
Context
The workaround involved renaming
SKILL.mdto<skillname>.md, creating symlinks back toSKILL.md, and adding skills to bothskillsandcommandsarrays inplugin.json. With the upstream fix, skills only need aSKILL.mdfile and an entry in theskillsarray.Confirmed working by this comment.
Changes
Skill file cleanup (29 skills across 8 plugins)
SKILL.mdsymlinks<skillname>.md→SKILL.md(real files with identical content)plugin.json updates (8 plugins)
commandsarrays in all 8 pluginsdevelopment-pr-workflow, 2 indevelopment-productivity)Bug fix
execute-planagent:**/skills/execute-plan/execute-plan.md→**/skills/execute-plan/SKILL.mdDocumentation updates
CLAUDE.md: update skill creation instructions (remove symlink/commands workaround), update version tableCLAUDE.mdfiles: update file trees and component tables to reflect clean structure (spec-workflow, uniswap-builder, claude-setup)Version Bumps
Test plan
commandsarraysvalidate-plugin.cjs