Skip to content

Commit 32aca99

Browse files
authored
Changed release build action to not publish to NuGet (#12)
- Multiple releases have shown that is problematic to do automated. - Everything else can be "undone" in some form. Publication to NuGet cannot. Thus, EXTREME care needs to come into play for any publication of packages. It can be scripted for simplification, but automated publication is causing too many issues with deprecations and de-listing etc... Co-authored-by: smaillet <25911635+smaillet@users.noreply.github.com>
1 parent fd0007d commit 32aca99

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

.github/workflows/release-build.yml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ permissions:
44
pages: write
55
packages: write
66
actions: read
7-
7+
88
defaults:
99
run:
1010
shell: pwsh
@@ -67,13 +67,16 @@ jobs:
6767
directory: .\BuildOutput\docs
6868
branch: gh-pages
6969

70-
- name: Publish packages to NuGet.org
71-
run: |
72-
if( [string]::IsNullOrWhiteSpace('${{secrets.NUGETPUSH_ACCESS_TOKEN}}'))
73-
{
74-
throw "'NUGETPUSH_ACCESS_TOKEN' does not exist, is empty or all whitespace!"
75-
}
76-
dotnet nuget push .\BuildOutput\NuGet\*.nupkg --api-key '${{secrets.NUGETPUSH_ACCESS_TOKEN}}' --source 'https://api.nuget.org/v3/index.json' --skip-duplicate
70+
# no automatic publication of NuGet packages, too much room for mistakes as publication to NuGet
71+
# cannot be undone. The packages must be manually published AFTER a successful GH release process
72+
# as a GH release ca be undone!
73+
# - name: Publish packages to NuGet.org
74+
# run: |
75+
# if( [string]::IsNullOrWhiteSpace('${{secrets.NUGETPUSH_ACCESS_TOKEN}}'))
76+
# {
77+
# throw "'NUGETPUSH_ACCESS_TOKEN' does not exist, is empty or all whitespace!"
78+
# }
79+
# dotnet nuget push .\BuildOutput\NuGet\*.nupkg --api-key '${{secrets.NUGETPUSH_ACCESS_TOKEN}}' --source 'https://api.nuget.org/v3/index.json' --skip-duplicate
7780

7881
- name: Create Release
7982
if: (!cancelled())

0 commit comments

Comments
 (0)