Skip to content

Commit fd0007d

Browse files
authored
Minor doc fixups (#10)
Co-authored-by: smaillet <25911635+smaillet@users.noreply.github.com>
1 parent 23bf7b7 commit fd0007d

File tree

4 files changed

+12
-6
lines changed

4 files changed

+12
-6
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This repo includes support for versioning numbers. This support includes:
1111
build numbering. It is NOT a CSemVer but IS a SemVer.
1212

1313
## Status
14-
![NuGet](https://img.shields.io/nuget/dt/Ubiquity.NET.Versioning.svg)
14+
[![NuGet Version](https://img.shields.io/nuget/v/Ubiquity.NET.Versioning)](https://www.nuget.org/packages/Ubiquity.NET.Versioning)![NuGet](https://img.shields.io/nuget/dt/Ubiquity.NET.Versioning.svg)
1515
![PR/CI Work Flow Status](https://img.shields.io/github/actions/workflow/status/UbiquityDotNET/Ubiquity.NET.Versioning/pr-build.yml?label=PR%2FCI%20Build%20Status)
1616
![Release Work Flow Status](https://img.shields.io/github/actions/workflow/status/UbiquityDotNET/Ubiquity.NET.Versioning/release-build.yml?label=Release%20Build%20Status)
1717

@@ -62,4 +62,4 @@ Documentation on building and general maintenance of this repo are provided in t
6262

6363
----
6464
<sup><a id="footnote_1">1</a></sup>See: [This issue](https://github.com/CK-Build/csemver.org/issues/2) which was reported upon
65-
testing this library and found inconsistencies.
65+
testing this library and found ambiguities.

docfx/versioning-lib/index.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,13 @@ The Ubiquity.NET.Versioning library provides types to support use of versioning
33
1) [Semantic Versioning](https://semver.org)
44
2) [Constrained Semantic Versioning](https://csemver.org)
55
- Including Continuous Integration (CI) via CSemVer-CI
6+
- Including FileVersion QUAD representation
7+
- Including OrderedVersion integral representation.
68

79
It is viable as a standalone package to allow validation of or comparisons to versions
810
reported at runtime. (Especially from native interop that does not support package
9-
dependencies or versioning at runtime.)
11+
dependencies or versioning at runtime.) The [Ubiquity.NET.Versioning.Build.Tasks](https://www.nuget.org/packages/Ubiquity.NET.Versioning.Build.Tasks)
12+
is a companion project that implements automated build support for CSemVer.
1013

1114
## Example
1215
``` C#

src/Ubiquity.NET.Versioning.UT/ParsedBuildVersionXmlTests.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
// -----------------------------------------------------------------------
66

77
using System;
8+
using System.Diagnostics.CodeAnalysis;
89
using System.IO;
910
using System.Xml.Linq;
1011

@@ -83,6 +84,7 @@ private static readonly XDocument InvalidAttributeXml
8384
)
8485
);
8586

87+
[SuppressMessage( "StyleCop.CSharp.NamingRules", "SA1310:Field names should not contain underscore", Justification = "Underscores substitute for otherwise invalid delimiter" )]
8688
private static readonly XDocument Xml_5_0_4
8789
= new( new XElement("BuildVersionData",
8890
new XAttribute("BuildMajor", "5"),

src/Ubiquity.NET.Versioning.UT/ValidationWithTask.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public void ValidateRepoAssemblyVersion( )
4040
// NOTE: Concept of a CI build used here (and in CSemVer[-CI]) is anything that is NOT
4141
// a release build. It does not distinguish between local, PR, or "nightly" etc...
4242
// That information is lost in creation of the FileVersionQuad form anyway and
43-
// only a single bit represents a CSemVer or CSemVer-CI.
43+
// only a single bit represents a CI build.
4444
BuildKind buildKind = GetBuildKind();
4545
bool isCIBuild = buildKind != BuildKind.ReleaseBuild;
4646

@@ -88,8 +88,9 @@ public void ValidateRepoAssemblyVersion( )
8888
// This is where the Patch+1 behavior is validated against the task
8989
// Both this library and the generated version for this library (from the task)
9090
// should agree on the build and base build. Bug: https://github.com/UbiquityDotNET/CSemVer.GitBuild/issues/64
91-
// on the task deals with the incorrect assumption that baseBuild == build and
92-
// generally ignores the Patch+1 requirement.
91+
// on the task dealt with the previously incorrect assumption that baseBuild == build and
92+
// generally ignored the Patch+1 requirement. That has since been fixed but worth keeping in mind
93+
// as this point has caused a great deal of confusion.
9394
Assert.AreEqual( expectedVersion.Major, actualCI.Major );
9495
Assert.AreEqual( expectedVersion.Minor, actualCI.Minor );
9596
Assert.AreEqual( expectedVersion.Patch, actualCI.Patch );

0 commit comments

Comments
 (0)