Skip to content

fix(ui5-tokenizer, ui5-multi-input,ui5-multi-combobox): Improve stylisation#13314

Merged
niyap merged 5 commits intomainfrom
tokenizerstylingissues
Mar 29, 2026
Merged

fix(ui5-tokenizer, ui5-multi-input,ui5-multi-combobox): Improve stylisation#13314
niyap merged 5 commits intomainfrom
tokenizerstylingissues

Conversation

@niyap
Copy link
Copy Markdown
Contributor

@niyap niyap commented Mar 22, 2026

  • Tokenizer max-width calculation is adjusted: the inner-input width is correct now, as well as the --_ui5-input-icons-count is set to the tokenizer element itself in addition to the host element. This ensures the variable is available in the tokenizer's shadow DOM context where the max-width calculation is performed. Previously, the variable was only set on the MultiInput host, but the tokenizer's max-width calculation could not access it, resulting in the icon count being 0 instead of the correct value.
  • inner-input-with-icon attribute is always set when an icon is presented, no matter of its kind.
  • last-visible-token attribute added in order to mark the last visible that does not overflow when N-more indicator is present
  • inner-input width and paddings are adjusted according to the specification covering all the use cases (icon presented, tokenizer available or just an input field)

JIRA: BGSOFUIRILA-3333
FIXES: #5096
FIXES: #13184

@niyap niyap requested review from Vonahz and ivoplashkov March 22, 2026 22:27
@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

ui5-webcomponents-bot commented Mar 22, 2026

🧹 Preview deployment cleaned up: https://pr-13314--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 22, 2026 22:34 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 24, 2026 12:57 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 26, 2026 06:55 Inactive
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 26, 2026 08:27 Inactive
@niyap niyap merged commit f9ff5ee into main Mar 29, 2026
20 of 22 checks passed
@niyap niyap deleted the tokenizerstylingissues branch March 29, 2026 10:47
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview March 29, 2026 10:47 Inactive
@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version v2.21.0-rc.4 🎉

The release is available on v2.21.0-rc.4

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MultiInput]: Incorrect Spacing between Tokenizer and Input Value ui5-tokenizer: Necessary improvements for proper stylisation

3 participants