fix(release): correct changelog extraction regex#13214
Merged
Conversation
The multiline flag causes $ to match end of every line, making the lazy capture group always return empty. This resulted in all 2.20.x GitHub releases having empty release notes. Change the lookahead from (?=^# \[|$) to (?=\n# \[|$(?!\n)) so $ only matches the true end of string, not end of each line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extractChangelog.mjsthat caused all 2.20.x GitHub releases to have empty release notesm(multiline) flag makes$match end of every line; combined with the lazy([\s\S]*?)capture group, the lookahead(?=^# \[|$)immediately matches at the next end-of-line, returning an empty string every time(?=\n# \[|$(?!\n))so$only matches the true end of stringTest plan
CHANGELOG.md