fix(ui5-form-item): fix label-content alignment#13119
Merged
Conversation
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-13119--ui5-webcomponents.netlify.app |
1 task
nnaydenow
approved these changes
Feb 23, 2026
Contributor
Author
|
🎉 This issue has been resolved in version v2.20.0-rc.2 🎉 The release is available on v2.20.0-rc.2 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix vertical alignment issue between form item labels and content introduced in
v2.19.0
Root Cause
In #13009, the CSS variable
--ui5-form-item-label-paddingwas setunconditionally on
:hostwith asymmetric padding (0.625rem 0.25rem 0 0.25rem).This padding was intended only for
label-span="12"(stacked layout) but wasbeing applied to all form items.
Fix
Rename the variable to
--ui5-form-item-label-padding-internalso it's only usedwhen the span12 selectors explicitly set
--ui5-form-item-label-padding: var(--ui5-form-item-label-padding-internal). This restores the symmetric defaultpadding (
0.125rem 0) from FormItem.css fallback.Fixes #13118