fix(ui5-multi-combobox): correct filtering when input doesn't match typeahead #12981
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ypeahead When typing text that doesn't trigger typeahead (e.g. "k" or "and"), the filter incorrectly used stale valueBeforeAutoComplete instead of the actual typed value, causing wrong suggestions to appear. Fixes: - Typing "k" showed all items instead of only matching "Kingdom" - Typing "and" showed items matching "a" instead of matching "and"
|
|
Collaborator
|
🧹 Preview deployment cleaned up: https://pr-12981--ui5-webcomponents.netlify.app |
niyap
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When typing text that doesn't trigger typeahead autocomplete (e.g., "k" or "and"), the filter incorrectly used a stale
valueBeforeAutoCompleteinstead of the actual typed value, causing wrong suggestions to appear.Symptoms:
Root Cause:
The condition
this._shouldAutocomplete || !!autoCompletedCharscaused filtering to usevalueBeforeAutoCompleteeven when there was no actual autocomplete. The_shouldAutocompleteflag is true during normal typing, butvalueBeforeAutoCompleteonly updates when typeahead finds a match.Fix:
Only use
valueBeforeAutoCompletewhen there are actually autocompleted characters selected (autoCompletedChars > 0).Test Plan