Revert "fix(ui5-input): fire submit only if single input in a form (#… #12892
+2
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 0944107.
Form submission is prevented only in the scenario where there are multiple input fields that accept free text and there is no submit element inside the form. Having a form with multiple input elements but no submit action is an unusual setup.
In order to avoid introducing complex detection logic for all possible cases, the decision of whether the form should be submitted is delegated to the application.
For this reason, this PR reverts the changes introduced by the following commit
Related to: #12221
Related to: #12629
Fixes: #12863