-
Notifications
You must be signed in to change notification settings - Fork 279
feat(ComboBox): implement noTypeahead behavior to skip auto-selection during filtering #12728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b3dd05e to
d3f9efc
Compare
… during filtering
d3f9efc to
71d3754
Compare
|
Hi @UI5/ui5-team-ctr-ril, Please take a look |
|
@MapTo0 @ndeshev @StefanDimitrov04 Hi folks, I've seen you recently reviewed/worked on combobox component, could you please take a look at this small bugfix when you'll have some time 🙏 |
|
Hello, its been now 2 weeks, without any reaction in this PR whatsoever. This is not really helpful, as we are currently stuck and cannot proceed with our project, hence having bad UX because the component is not usable right now which mades us being stuck with a dropdown that simply shows all options. What do we need to do in order to get progress here? I am tagging random ppls that contributed to this repo, as I want to get someone to at least take a look so that this is not just forgotten. |
|
@mavo as i have written in the issue itself - i have conveyed this to our designers. They have not provided timeline, but they said that this needs to be discussed on their internal round and they will come back to me once they do so. I will get back to you then. This is something that may be considered backward incompatible, thus we need to be backed up by the design area. We have already checked the code and once we hear from them we can quickly act - either approve or reject the pull request. The request has not been forgotten, it needs to be discussed and synced in a larger round as there are other technologies that use this components and all design representatives consulted. |
|
Reopening this PR, the Design colleagues are still to state their thoughts on the matter. Design BLI is in progress: FIORIDESIGN-15397 |
Thank you for your contribution! 👏
Fixes: #12727
PR checklist
Check the Development Hints
Follow the Commit message Guidelines
For example:
fix(ui5-*): correct/fix sthorfeat(ui5-*): add/introduce sth. If you don't want the change to be part of the release changelog - usechore,refactorordocs.Add proper description about the background of the change and the change itself
Link to an existing issue (if available)
Use
Fixes: {#PR_NUMBER}to close the issue automatically when the PR is mergedor
Related to: {#PR_NUMBER}to just create a link between the PR and the issue.Background
When using ComboBox with the
noTypeaheadproperty enabled, items were being automatically selected as the user typed, even though the expected behavior is to only allow explicit user selection. This created confusion asnoTypeaheadis intended to disable autocomplete/auto-selection behavior, providing only filtering functionality.Changes
Modified the
_selectMatchingItem()method inComboBox.tsto skip auto-selection during active filtering whennoTypeahead=true.Implementation details:
!_selectionPerformed)!_isKeyNavigation)noTypeahead=trueand the above conditions are met, auto-selection is skippednoTypeahead=falseremains unchangedTesting
Added 5 comprehensive Cypress test cases covering:
noTypeahead=truenoTypeahead=false