Improve test setup

.github/workflows/github-ci.yml

@@ -27,6 +27,28 @@ jobs:
     - name: Install dependencies
       run: npm ci --engine-strict # --engine-strict is used to fail-fast if deps require node versions unsupported by the repo
 
+    - name: Check package.json "engines" consistency
+      run: |
+        node << 'EOF'
+        const { execSync } = require('child_process');
+        const fs = require('fs');
+
+        const rootPkg = JSON.parse(fs.readFileSync('package.json', 'utf8'));
+        const workspaces = JSON.parse(execSync('npm query .workspace --json', { encoding: 'utf8' }));
+
+        let hasError = false;
+        workspaces.forEach(pkg => {
+          if (JSON.stringify(pkg.engines) !== JSON.stringify(rootPkg.engines)) {
+            console.error(`❌ ${pkg.location}/package.json "engines" mismatch with root package.json`);
+            hasError = true;
+          }
+        });
+
+        if (hasError) process.exit(1);
+        console.log('✅ All workspace packages "engines" are consistent with root package.json');
+
+        EOF
+
     - name: Perform ESLint check
       run: npm run lint
 

ava.common.config.js

@@ -0,0 +1,16 @@
+export default {
+	files: [
+		"test/lib/**/*.js",
+		"!test/**/__helper__/**"
+	],
+	watchMode: {
+		ignoreChanges: [
+			"test/tmp/**"
+		],
+	},
+	nodeArguments: [
+		"--loader=esmock",
+		"--no-warnings"
+	],
+	workerThreads: false,
+};

internal/benchmark/package.json

@@ -3,6 +3,10 @@
 	"private": true,
 	"license": "Apache-2.0",
 	"type": "module",
+	"engines": {
+		"node": "^22.20.0 || >=24.0.0",
+		"npm": ">= 8"
+	},
 	"bin": {
 		"ui5-cli-benchmark": "./cli.js"
 	},

internal/shrinkwrap-extractor/package.json

@@ -22,9 +22,9 @@
 		"test": "npm run lint && npm run coverage && npm run depcheck",
 		"unit": "node --test test/lib/convertToShrinkwrap.js",
 		"unit-watch": "node --test --watch test/lib/convertToShrinkwrap.js",
-		"coverage": "nyc node --test test/lib/convertToShrinkwrap.js",
+		"coverage": "node --test --experimental-test-coverage 'test/lib/convertToShrinkwrap.js'",
 		"lint": "eslint .",
-		"depcheck": "depcheck --ignores @ui5/shrinkwrap-extractor,@eslint/js,eslint-config-google,globals,nyc"
+		"depcheck": "depcheck"
 	},
 	"keywords": [
 		"npm",
@@ -34,32 +34,17 @@
 		"dependencies"
 	],
 	"type": "module",
+	"engines": {
+		"node": "^22.20.0 || >=24.0.0",
+		"npm": ">= 8"
+	},
 	"dependencies": {
 		"@npmcli/arborist": "^9.1.7",
 		"@npmcli/config": "^10.4.0",
 		"pacote": "^21.0.4"
 	},
 	"devDependencies": {
-		"@eslint/js": "^9.39.1",
 		"depcheck": "^1.4.7",
-		"eslint-config-google": "^0.14.0",
-		"globals": "^16.5.0",
-		"nyc": "^17.1.0"
-	},
-	"nyc": {
-		"reporter": [
-			"lcov",
-			"text",
-			"text-summary"
-		],
-		"exclude": [
-			"coverage/**",
-			"test/**"
-		],
-		"check-coverage": true,
-		"statements": 80,
-		"branches": 75,
-		"functions": 75,
-		"lines": 80
+		"eslint": "^9.39.1"
 	}
 }

nyc.common.config.js

@@ -0,0 +1,33 @@
+export default {
+	"reporter": [
+		"lcov",
+		"text",
+		"text-summary"
+	],
+	"exclude": [
+		"coverage/**",
+		"test/**",
+		"*.config.js"
+	],
+	"check-coverage": true,
+	"watermarks": {
+		"statements": [
+			70,
+			90
+		],
+		"branches": [
+			70,
+			90
+		],
+		"functions": [
+			70,
+			90
+		],
+		"lines": [
+			70,
+			90
+		]
+	},
+	"cache": true,
+	"all": true
+};

package.json

@@ -30,6 +30,7 @@
 		"coverage": "npm run coverage --workspaces --if-present",
 		"depcheck": "depcheck --ignores @ui5/builder,@ui5/cli,@ui5/fs,@ui5/logger,@ui5/project,@ui5/server,local-web-server,@commitlint/config-conventional,husky && npm run depcheck --workspaces --if-present",
 		"check-licenses": "licensee --errors-only",
+		"schema-generate": "npm run schema-generate --workspace=@ui5/documentation",
 		"generate-cli-doc": "npm run generate-cli-doc --workspace=@ui5/documentation"
 	},
 	"repository": {

packages/builder/ava.config.js

@@ -0,0 +1,3 @@
+import avaCommonConfig from "../../ava.common.config.js";
+
+export default avaCommonConfig;

packages/builder/nyc.config.js

@@ -0,0 +1,12 @@
+import nycCommonConfig from "../../nyc.common.config.js";
+
+// Exclude jsdoc library files from coverage as they are originally maintained at https://github.com/UI5/openui5/tree/master/lib/jsdoc
+nycCommonConfig.exclude.push("lib/processors/jsdoc/lib/**");
+
+export default {
+	...nycCommonConfig,
+	"statements": 95,
+	"branches": 90,
+	"functions": 95,
+	"lines": 95,
+};

packages/builder/package.json

@@ -40,32 +40,13 @@
 		"unit-watch": "rimraf test/tmp && ava --watch",
 		"unit-inspect": "cross-env UI5_LOG_LVL=verbose ava debug --break",
 		"coverage": "rimraf test/tmp && nyc ava --node-arguments=\"--experimental-loader=@istanbuljs/esm-loader-hook\"",
-		"preversion": "npm test",
-		"version": "git-chglog --sort semver --next-tag v$npm_package_version -o CHANGELOG.md v4.0.0.. && git add CHANGELOG.md",
-		"prepublishOnly": "git push --follow-tags",
-		"release-note": "git-chglog --sort semver -c .chglog/release-config.yml v$npm_package_version",
 		"depcheck": "depcheck --ignores @ui5/builder,@istanbuljs/esm-loader-hook,catharsis,rimraf,jsdoc --parsers='**/*.js:es6,**/*.cjs:es6'"
 	},
 	"files": [
 		"CHANGELOG.md",
 		"lib/**",
 		"LICENSES/**"
 	],
-	"ava": {
-		"files": [
-			"test/lib/**/*.js"
-		],
-		"watchMode": {
-			"ignoreChanges": [
-				"test/tmp/**"
-			]
-		},
-		"nodeArguments": [
-			"--loader=esmock",
-			"--no-warnings"
-		],
-		"workerThreads": false
-	},
 	"nyc": {
 		"reporter": [
 			"lcov",

packages/cli/ava.config.js

@@ -0,0 +1,5 @@
+import avaCommonConfig from "../../ava.common.config.js";
+
+avaCommonConfig.files.push("test/bin/**/*.js");
+
+export default avaCommonConfig;

packages/cli/nyc.config.js

@@ -0,0 +1,9 @@
+import nycCommonConfig from "../../nyc.common.config.js";
+
+export default {
+	...nycCommonConfig,
+	"statements": 95,
+	"branches": 90,
+	"functions": 85,
+	"lines": 95,
+};