Added timestamps to logging messages (node)#62
Open
TheBv wants to merge 1 commit intoUCL-VR:masterfrom
Open
Conversation
Member
|
Hi @TheBv, our apologies for the delay in reviewing your PR. We will review it soon and get back to you. Thanks so much for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added timestamps to all the various logging messages for the ubiq-server.
This has been a minor annoyance for some time now when triaging things so I finally fixed things.
We could also look into using a library for this e.g. https://www.npmjs.com/package/js-logger or something similar if you want :)
I'd be happy to swap things out!
I also audited the npm dependencies to resolve vulnerabilities.