trace: fix SIGSEGV after pop 2 #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `trace_pop_target()` invalidates the linked list of `target_stack_node_t`s by `free()`ing the node and its `p_target`. But `p_stack_top` may still points at that now freed node. Entering the debugger will crash as it will start from `p_stack_top`. 1. Explicitly invalidate `p_target` by setting it to `NULL`. 2. Explicitly pop the top node from `p_stack_top` before calling `trace_pop_target()`. Closes: Trepan-Debuggers#158 Fixes: a86f3c0 ("trace: fix SIGSEGV after pop") Signed-off-by: Philipp Hahn <[email protected]>
Collaborator
|
Seems a little hacky, but ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
trace_pop_target()invalidates the linked list oftarget_stack_node_ts byfree()ing the node and itsp_target.But
p_stack_topmay still points at that now freed node. Entering the debugger will crash as it will start fromp_stack_top.p_targetby setting it toNULL.p_stack_topbefore callingtrace_pop_target().Closes: #158
Fixes: a86f3c0 ("trace: fix SIGSEGV after pop")