Refactoring/master V3#7
Conversation
… prevede blocchi (intent) con una sola action, drag & drop ridotto al solo trascinamento dal pannello sullo stage, e rimozione dei controlli di editing inline sulle action.
…SSIGNED, CLEAR_TRANSCRIPT
Replace cds-action-reply with cds-action-reply-new in three template files: - cds-intent.component.html: REPLY and RANDOM_REPLY cases - cds-panel-action-detail.component.html: REPLY and RANDOM_REPLY cases - cds-panel-detail.component.html: REPLY and RANDOM_REPLY cases This switches the UI to use the refactored DS V3 component with new layout, styling, and pixel-perfect Reply Inspector design. Build verified without errors. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Initialize arrayResponses from action.attributes.commands in ngOnInit, not just in ngOnChanges. This ensures data loads when component inputs are already set at creation time. Prevents empty reply state. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Switch back from cds-action-reply-new to cds-action-reply in all templates: - cds-intent.component.html - cds-panel-action-detail.component.html - cds-panel-detail.component.html Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add debug comment to verify new component loads - Add missing @input() connector to new component for compatibility - Activate new component in all three templates: * cds-intent.component.html (REPLY + RANDOM_REPLY cases) * cds-panel-action-detail.component.html (REPLY + RANDOM_REPLY cases) * cds-panel-detail.component.html (REPLY + RANDOM_REPLY cases) Build verified: successfully compiled with zero errors. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
The cds-actions-new.module.ts has missing imports (clone script incomplete). Reverted to old cds-action-reply component while the new module is being completed. New component remains in place with debug logging for testing when module is ready. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Add badge: 'V3' to REPLY and RANDOM_REPLY in utils-actions.ts - Add .badge-V3 styling with green gradient in cds-action-description.component.scss - Badge appears in action detail panel for visual identification of V3 components Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 5 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1932cc0. Configure here.
| this.action[property] = $event; | ||
| } | ||
| // this.updateAndSaveAction.emit({type: TYPE_UPDATE_ACTION.ACTION, element: this.action}); | ||
| } |
There was a problem hiding this comment.
KB edits are dropped
Medium Severity
name and source edits are never copied into action, so saving after editing the KB question or answer keeps the old values; content is also recomputed from stale state.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1932cc0. Configure here.
| this.intentService.onChangedConnector({fromId: idConnector, idCondition: idCondition}); | ||
| this.logger.log("[ACTION AI_CONDITION] addNewCondition", this.listOfConnectors); | ||
| // this.updateAndSaveAction.emit(); | ||
| } |
There was a problem hiding this comment.
New conditions are not saved
Medium Severity
addNewCondition() mutates action.intents but never emits updateAndSaveAction, so a newly added condition disappears unless another later edit happens to save the action.
Reviewed by Cursor Bugbot for commit 1932cc0. Configure here.
| } | ||
| this.logger.log("[ACTION AI_CONDITION] onDeleteCondition - remaining intents:", this.action.intents); | ||
| this.logger.log("[ACTION AI_CONDITION] onDeleteCondition - remaining connectors:", this.listOfConnectors); | ||
| this.updateAndSaveAction.emit(); |
There was a problem hiding this comment.
Deleted conditions leave connectors
Medium Severity
onDeleteCondition() removes the condition locally but does not emit a connector delete event, leaving any existing connector for that branch orphaned on the canvas.
Reviewed by Cursor Bugbot for commit 1932cc0. Configure here.
| height: 43px; | ||
| border-radius: var(--input-border-radius-base); | ||
| border: 1px solid var(--blu-light-02); | ||
| border: 1px solid var(--border); |
There was a problem hiding this comment.
Undefined border token
Medium Severity
--border is used as a shared token, but it is not defined globally. Components outside cds-panel-detail lose these border/color styles because declarations using var(--border) become invalid.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 1932cc0. Configure here.
| "src/environments/real_data/cds-config-native-collaudo.json", | ||
| "src/environments/real_data/cds-config-aws-stage.json" | ||
| "src/environments/real_data/cds-config-aws-stage.json", | ||
| { "glob": "cds-config-local.json", "input": "src/environments/real_data", "output": "/real_data" } |
There was a problem hiding this comment.
Local config enters builds
Medium Severity
cds-config-local.json is marked as local dev config, but angular.json now copies it into every build when present. Local-only values can be shipped in production artifacts.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1932cc0. Configure here.
|
You have used all of your free Bugbot PR reviews. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
1 participant
Note
Medium Risk
Medium risk due to introducing a parallel set of V3
list-newaction components (new selectors, modules, and connector logic) and updating shared styling variables, which could cause runtime/template issues if any selector/module wiring is incorrect.Overview
Bumps the app to
2.0.1("v3") and adds Node pinning via.nvmrc, plus a local dev config path ignored in.gitignoreand packaged into the build viaangular.jsonassets.Introduces a new V3 actions tree under
cds-canvas/actions/list-new(with helper scripts to clone/rename selectors) including new/ported action UIs likecds-action-ai-condition-new,cds-action-ai-prompt-new, KB/tag actions, and associated dialogs/styles/tests, and wires some of these new components intocds-canvas.module.ts.Updates many shared component SCSS files to switch from legacy
--blu*variables to the newer design-system tokens (e.g.--ds-bg,--ds-ink,--border), affecting global look-and-feel consistency.Reviewed by Cursor Bugbot for commit 1932cc0. Bugbot is set up for automated code reviews on this repo. Configure here.