Skip to content

fix: add missing output pointer validation in array schema conversion functions #5787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teo-tsirpanis merged 1 commit into from
Mar 27, 2026
+4 −0
Merged

fix: add missing output pointer validation in array schema conversion functions #5787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tiledb/api/c_api/array_schema/array_schema_api.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ namespace tiledb::api {

capi_return_t tiledb_array_type_to_str(
tiledb_array_type_t array_type, const char** str) {
ensure_output_pointer_is_valid(str);
const auto& strval =
tiledb::sm::array_type_str((tiledb::sm::ArrayType)array_type);
*str = strval.c_str();
Expand All @@ -57,6 +58,7 @@ capi_return_t tiledb_array_type_to_str(

capi_return_t tiledb_array_type_from_str(
const char* str, tiledb_array_type_t* array_type) {
ensure_output_pointer_is_valid(array_type);
tiledb::sm::ArrayType val = tiledb::sm::ArrayType::DENSE;
if (!tiledb::sm::array_type_enum(str, &val).ok()) {
return TILEDB_ERR;
Expand All @@ -66,12 +68,14 @@ capi_return_t tiledb_array_type_from_str(
}

capi_return_t tiledb_layout_to_str(tiledb_layout_t layout, const char** str) {
ensure_output_pointer_is_valid(str);
const auto& strval = tiledb::sm::layout_str((tiledb::sm::Layout)layout);
*str = strval.c_str();
return strval.empty() ? TILEDB_ERR : TILEDB_OK;
}

capi_return_t tiledb_layout_from_str(const char* str, tiledb_layout_t* layout) {
ensure_output_pointer_is_valid(layout);
tiledb::sm::Layout val = tiledb::sm::Layout::ROW_MAJOR;
if (!tiledb::sm::layout_enum(str, &val).ok()) {
return TILEDB_ERR;
Expand Down
Loading