Merged
Conversation
rroelke
approved these changes
Mar 27, 2026
Member
rroelke
left a comment
rroelke
left a comment
There was a problem hiding this comment.
I also find minimal value in these tests. But somebody somewhere is twitching, I'm sure.
teo-tsirpanis
deleted the
teo/core-523-remove-check-that-all-object-libraries-are-independently
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we are shipping TileDB as a single unit, and because object libraries are an implementation detail, having checks that each object library can be independently linked (with explicitly stated dependencies) provides zero practical benefit, while adding almost one hundred
compile_***_.ccfiles to source control.Any link errors that might occur in shipping libraries or unit tests will be caught in CI and addressed accordingly.
This also lets us use the standard
commence/concludepattern for all remaining object libraries.TYPE: NO_HISTORY