Skip to content

fix: do not delete existing object on upload #5778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teo-tsirpanis merged 1 commit into from
Mar 16, 2026
+0 −14
Merged

fix: do not delete existing object on upload #5778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions tiledb/sm/filesystem/azure.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,11 +1115,6 @@ void Azure::write_blocks(

auto state_iter = block_list_upload_states_.find(uri.to_string());
if (state_iter == block_list_upload_states_.end()) {
// Delete file if it exists (overwrite).
if (is_file(uri)) {
remove_file(uri);
}

// Instantiate the new state.
BlockListUploadState state;

Expand Down
5 changes: 0 additions & 5 deletions tiledb/sm/filesystem/gcs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1034,11 +1034,6 @@ Status GCS::write_parts(

// Downgrade to read lock, expected below outside the create
unique_wl.unlock();

// Delete file if it exists (overwrite).
if (is_file(uri)) {
remove_file(uri);
}
} else {
// If another thread switched state, switch back to a read lock
state = &multi_part_upload_states_.at(uri.to_string());
Expand Down
4 changes: 0 additions & 4 deletions tiledb/sm/filesystem/s3.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1227,10 +1227,6 @@ void S3::global_order_write(
state_ptr = &state_iter->second;

unique_wl.unlock();

if (is_file(uri)) {
remove_file(uri);
}
} else {
state_ptr = &state_iter->second;
// Unlock, as make_upload_part_req will reaquire as necessary.
Expand Down
Loading