Add support for aws login authentication.#5776
Merged
teo-tsirpanis merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
teo-tsirpanis
commented
Mar 11, 2026
| // going to be added upstream soon with | ||
| // https://github.com/aws/aws-sdk-cpp/pull/2860, let's not update it for now. | ||
| AddProvider(make_shared<SSOCredentialsProvider>(HERE())); | ||
| if (clientConfig) { |
Member
Author
There was a problem hiding this comment.
This condition is always true in practice.
ypatia
approved these changes
Mar 16, 2026
Member
ypatia
left a comment
ypatia
left a comment
There was a problem hiding this comment.
LGTM! Let's also update docs in AWSCredentialsProviderChain.h.
teo-tsirpanis
deleted the
teo/core-518-add-support-for-aws-login-authentication
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an instance of the newly added
Aws::Auth::LoginCredentialsProviderclass to our custom default AWS provider chain. This enables the S3 VFS to obtain credentials configured with theaws clicommand.Validated locally by running an example after modifying it to write to S3.
TYPE: FEATURE
DESC: Added support for authenticating to S3 using console credentials, configured with the
aws loginCLI command.