-
Notifications
You must be signed in to change notification settings - Fork 768
Gui: 3DBX fix ruler #9264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Gui: 3DBX fix ruler #9264
Conversation
Signed-off-by: LucasYuki <[email protected]>
Signed-off-by: LucasYuki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request addresses issue #9089 by refactoring the ruler functionality to correctly handle multiple blocks within the layout. The changes involve iterating through all chip_insts and performing searches within each block's coordinate system. The getBounds function now correctly merges bounding boxes and die areas from all blocks, applying necessary transformations. The searchNearestViaEdge and selectViaShapesAt functions have been updated to accept a dbBlock* parameter, allowing them to operate within the context of a specific block. The review comments highlight a critical issue with coordinate transformations that could lead to incorrect results when handling closest_edge across different blocks.
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: LucasYuki <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
|
This PR does not work for me
I tested with and couldn't snap to the upper die at all. |
Closes issue #9089
Changes: